Bug 275291

Summary: net/py-zeroconf missing dependency
Product: Ports & Packages Reporter: Stephen Hurd <shurd>
Component: Individual Port(s)Assignee: John Hixson <jhixson>
Status: Closed FIXED    
Severity: Affects Only Me CC: jhixson, madpilot
Priority: --- Flags: bugzilla: maintainer-feedback? (jhixson)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch v1 madpilot: maintainer-approval? (jhixson)

Description Stephen Hurd freebsd_committer freebsd_triage 2023-11-24 06:35:11 UTC 
The lib/python3.9/site-packages/zeroconf/_utils/asyncio.py file installed by net/py-zeroconf imports async_timeout, but devel/py-async_timeout is not a dependency, causing software that uses py-zeroconf (such as deskutils/calibre) to fail.
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2023-11-29 09:10:24 UTC 
Created attachment 246654 [details]
patch v1

HI,

I can confirm this issue. I noticed it while testing calibre server functionality (from deskutils/calibre).

I'm attaching a patch that adds the dependency for approval.

Thanks in advance!
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-12-15 15:14:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b73567fa42be40b945b81e981836ca9f1cc6a6f4

commit b73567fa42be40b945b81e981836ca9f1cc6a6f4
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2023-12-15 15:12:36 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2023-12-15 15:12:36 +0000

    net/py-zeroconf: Add missing dependency

    PR:             275291
    Approved by:    jhixson@ (maintainer timeout)
    MFH:            2023Q4

 net/py-zeroconf/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-12-15 15:15:11 UTC 
A commit in branch 2023Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=481e8d83b47c0c7a39911c65e93b823a181e4c4d

commit 481e8d83b47c0c7a39911c65e93b823a181e4c4d
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2023-12-15 15:12:36 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2023-12-15 15:14:32 +0000

    net/py-zeroconf: Add missing dependency

    PR:             275291
    Approved by:    jhixson@ (maintainer timeout)
    MFH:            2023Q4

    (cherry picked from commit b73567fa42be40b945b81e981836ca9f1cc6a6f4)

 net/py-zeroconf/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2023-12-15 15:16:44 UTC 
Patch committed with timeout.

I also merged this to quarterly, since it fixes an actual problem.

Thanks!