Bug 275296

Summary: security_daily_compat_var() in periodic.conf still retained though should have been removed after 11
Product: Base System Reporter: Michael Osipov <michaelo>
Component: confAssignee: Michael Osipov <michaelo>
Status: Closed FIXED    
Severity: Affects Only Me CC: michaelo
Priority: ---    
Version: 15.0-CURRENT   
Hardware: Any   
OS: Any   

Description Michael Osipov freebsd_committer freebsd_triage 2023-11-24 09:21:15 UTC
https://github.com/freebsd/freebsd-src/blob/main/usr.sbin/periodic/periodic.conf contains a function security_daily_compat_var() which says it is supposed to be removed in stable/11: https://github.com/freebsd/freebsd-src/blob/5e16809c953f4cd19fadb1767469dec319de0353/usr.sbin/periodic/periodic.conf#L341-L344

An oversight or just misleading documentation?
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-05-03 07:40:38 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=aa48259f337100e79933d660fec8856371f761ed

commit aa48259f337100e79933d660fec8856371f761ed
Author:     Michael Osipov <michaelo@FreeBSD.org>
AuthorDate: 2024-04-15 11:05:17 +0000
Commit:     Michael Osipov <michaelo@FreeBSD.org>
CommitDate: 2024-05-03 07:38:55 +0000

    periodic.conf: remove long deprecated security_daily_compat_var()

    This function is documented to be gone in after 11. Time to remove this
    compat shim.

    PR:             275296
    Reviewed by:    jrm (mentor)
    MFC after:      1 month
    Differential Revision:  https://reviews.freebsd.org/D44796

 usr.sbin/periodic/etc/security/100.chksetuid      |  2 --
 usr.sbin/periodic/etc/security/110.neggrpperm     |  2 --
 usr.sbin/periodic/etc/security/200.chkmounts      |  4 ----
 usr.sbin/periodic/etc/security/300.chkuid0        |  2 --
 usr.sbin/periodic/etc/security/400.passwdless     |  2 --
 usr.sbin/periodic/etc/security/410.logincheck     |  2 --
 usr.sbin/periodic/etc/security/500.ipfwdenied     |  2 --
 usr.sbin/periodic/etc/security/510.ipfdenied      |  2 --
 usr.sbin/periodic/etc/security/520.pfdenied       |  2 --
 usr.sbin/periodic/etc/security/550.ipfwlimit      |  2 --
 usr.sbin/periodic/etc/security/610.ipf6denied     |  2 --
 usr.sbin/periodic/etc/security/700.kernelmsg      |  2 --
 usr.sbin/periodic/etc/security/800.loginfail      |  3 ---
 usr.sbin/periodic/etc/security/900.tcpwrap        |  3 ---
 usr.sbin/periodic/etc/security/security.functions |  3 ---
 usr.sbin/periodic/periodic.conf                   | 22 ----------------------
 16 files changed, 57 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-06-05 08:07:37 UTC
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=0e0919db966a83efc696d19b39a5962500e6ad46

commit 0e0919db966a83efc696d19b39a5962500e6ad46
Author:     Michael Osipov <michaelo@FreeBSD.org>
AuthorDate: 2024-04-15 11:05:17 +0000
Commit:     Michael Osipov <michaelo@FreeBSD.org>
CommitDate: 2024-06-05 08:05:54 +0000

    periodic.conf: remove long deprecated security_daily_compat_var()

    This function is documented to be gone in after 11. Time to remove this
    compat shim.

    PR:             275296
    Reviewed by:    jrm (mentor)
    MFC after:      1 month
    Differential Revision:  https://reviews.freebsd.org/D44796

    (cherry picked from commit aa48259f337100e79933d660fec8856371f761ed)

 usr.sbin/periodic/etc/security/100.chksetuid      |  2 --
 usr.sbin/periodic/etc/security/110.neggrpperm     |  2 --
 usr.sbin/periodic/etc/security/200.chkmounts      |  4 ----
 usr.sbin/periodic/etc/security/300.chkuid0        |  2 --
 usr.sbin/periodic/etc/security/400.passwdless     |  2 --
 usr.sbin/periodic/etc/security/410.logincheck     |  2 --
 usr.sbin/periodic/etc/security/500.ipfwdenied     |  2 --
 usr.sbin/periodic/etc/security/510.ipfdenied      |  2 --
 usr.sbin/periodic/etc/security/520.pfdenied       |  2 --
 usr.sbin/periodic/etc/security/550.ipfwlimit      |  2 --
 usr.sbin/periodic/etc/security/610.ipf6denied     |  2 --
 usr.sbin/periodic/etc/security/700.kernelmsg      |  2 --
 usr.sbin/periodic/etc/security/800.loginfail      |  3 ---
 usr.sbin/periodic/etc/security/900.tcpwrap        |  3 ---
 usr.sbin/periodic/etc/security/security.functions |  3 ---
 usr.sbin/periodic/periodic.conf                   | 22 ----------------------
 16 files changed, 57 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-06-05 08:10:39 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=ac339672fbb46b3beac5eeb339ed5a67910b3f58

commit ac339672fbb46b3beac5eeb339ed5a67910b3f58
Author:     Michael Osipov <michaelo@FreeBSD.org>
AuthorDate: 2024-04-15 11:05:17 +0000
Commit:     Michael Osipov <michaelo@FreeBSD.org>
CommitDate: 2024-06-05 08:08:28 +0000

    periodic.conf: remove long deprecated security_daily_compat_var()

    This function is documented to be gone in after 11. Time to remove this
    compat shim.

    PR:             275296
    Reviewed by:    jrm (mentor)
    MFC after:      1 month
    Differential Revision:  https://reviews.freebsd.org/D44796

    (cherry picked from commit aa48259f337100e79933d660fec8856371f761ed)

 usr.sbin/periodic/etc/security/100.chksetuid      |  2 --
 usr.sbin/periodic/etc/security/110.neggrpperm     |  2 --
 usr.sbin/periodic/etc/security/200.chkmounts      |  4 ----
 usr.sbin/periodic/etc/security/300.chkuid0        |  2 --
 usr.sbin/periodic/etc/security/400.passwdless     |  2 --
 usr.sbin/periodic/etc/security/410.logincheck     |  2 --
 usr.sbin/periodic/etc/security/500.ipfwdenied     |  2 --
 usr.sbin/periodic/etc/security/510.ipfdenied      |  2 --
 usr.sbin/periodic/etc/security/520.pfdenied       |  2 --
 usr.sbin/periodic/etc/security/550.ipfwlimit      |  2 --
 usr.sbin/periodic/etc/security/610.ipf6denied     |  2 --
 usr.sbin/periodic/etc/security/700.kernelmsg      |  2 --
 usr.sbin/periodic/etc/security/800.loginfail      |  3 ---
 usr.sbin/periodic/etc/security/900.tcpwrap        |  3 ---
 usr.sbin/periodic/etc/security/security.functions |  3 ---
 usr.sbin/periodic/periodic.conf                   | 22 ----------------------
 16 files changed, 57 deletions(-)