Summary: | graphics/qt6-svg: null dereference crash when launching telegram-desktop after 6.6.0 upgrade | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Guido Falsi <madpilot> | ||||
Component: | Individual Port(s) | Assignee: | freebsd-kde (group) <kde> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | jhale, kde, osa | ||||
Priority: | --- | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
URL: | https://github.com/qt/qtsvg/commit/effc44495a33babd4cf7a2044123f420e6b3da1c | ||||||
See Also: |
https://github.com/telegramdesktop/tdesktop/issues/27134 https://bugreports.qt.io/browse/QTBUG-117944 |
||||||
Attachments: |
|
Description
Guido Falsi
2023-11-26 10:03:58 UTC
Adding osa to this bug since he has been updating the port and may have knowledge useful to fix it. I found some useful information via SUSE forums: https://lists.opensuse.org/archives/list/factory@lists.opensuse.org/thread/M53D4PDB2Q5FIJA6XU4KPLJBPM362VUT/ Looks like the qt bug is https://bugreports.qt.io/browse/QTBUG-117944 I'll try to cook up a patch including the upstream fix. I finally found the commit with a fix: https://github.com/qt/qtsvg/commit/effc44495a33babd4cf7a2044123f420e6b3da1c I've created a patch that fixes it in the ports tree. Tested it in poudriere, and running fine on head. Hope this can be approved/merged soon. Created attachment 246579 [details] patch v1 Patch applying https://github.com/qt/qtsvg/commit/effc44495a33babd4cf7a2044123f420e6b3da1c from upstream Approved! Please go ahead and commit. I should have Qt 6.6.1 ready around the middle of this week which includes this patch, but probably better to patch it now in case I run into problems or upstream delays the release again. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=986fd4e1a413aab152d54026fd0df8bd87b6da45 commit 986fd4e1a413aab152d54026fd0df8bd87b6da45 Author: Guido Falsi <madpilot@FreeBSD.org> AuthorDate: 2023-11-26 16:15:10 +0000 Commit: Guido Falsi <madpilot@FreeBSD.org> CommitDate: 2023-11-26 16:15:10 +0000 graphics/qt6-svg: Import patch to fix null dereference at runtime PR: 275350 Approved by: kde (jhale) Obtained from: https://github.com/qt/qtsvg/commit/effc44495a33babd4cf7a2044123f420e6b3da1c graphics/qt6-svg/Makefile | 1 + graphics/qt6-svg/files/patch-src_svg_qsvghandler.cpp (new) | 11 +++++++++++ 2 files changed, 12 insertions(+) (In reply to Jason E. Hale from comment #5) Thanks for the fast approval, just committed it. I was not sure when 6.6.1 was planned to land, and I thought this one was bad enough to warrant a dedicated patch. Thanks again for all the work on qt and kde! |