Bug 275652

Summary: sysutils/runj: upgrade from g20230316 to g20230821
Product: Ports & Packages Reporter: Vasil Dimov <vd>
Component: Individual Port(s)Assignee: Dave Cottlehuber <dch>
Status: Closed FIXED    
Severity: Affects Some People Flags: bugzilla: maintainer-feedback? (dch)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
upgrade
none
v2 none

Description Vasil Dimov freebsd_committer freebsd_triage 2023-12-09 08:41:30 UTC
Created attachment 246925 [details]
upgrade

sysutils/runj: upgrade from g20230316 to g20230821

I am not sure about Makefile.deps - how to check whether it needs an update and how to generate it?
Comment 1 Dave Cottlehuber freebsd_committer freebsd_triage 2024-01-04 22:39:37 UTC
Created attachment 247448 [details]
v2

Hey Vasil, I do this:

- update makefile with date & git commit

rm distinfo Makefile.deps
make makesum
truncate -S 0 Makefile.deps
make gomod-vendor | tee /tmp/Makefile.deps
grep -Ev '^=*>' /tmp/Makefile.deps > Makefile.deps

It usually needs a little massaging before it works.

## again to pick up new go modules
make makesum

that's it.

This time, the build fails for a go build error that I can't decipher,
hence the delayed update. See https://github.com/samuelkarp/runj/issues/55
for details.

===>  Building runj-entrypoint from ./cmd/runj-entrypoint
github.com/containerd/console
go.sbk.wtf/runj/cmd/runj-entrypoint
===>  Building containerd-shim-runj-v1 from ./cmd/containerd-shim-runj-v1
go: finding module for package google.golang.org/genproto/googleapis/rpc/status
vendor/github.com/containerd/ttrpc/types.go:22:2: cannot query module due to -mod=vendor
*** Error code 1


Perhaps you have some ideas? My WIP attached.
Comment 2 Vasil Dimov freebsd_committer freebsd_triage 2024-01-05 09:11:42 UTC
No idea :(
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-01-10 15:39:05 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a39248f5f5f52f0a425127a760b4846093357864

commit a39248f5f5f52f0a425127a760b4846093357864
Author:     Dave Cottlehuber <dch@FreeBSD.org>
AuthorDate: 2024-01-10 15:38:05 +0000
Commit:     Dave Cottlehuber <dch@FreeBSD.org>
CommitDate: 2024-01-10 15:38:05 +0000

    sysutils/runj: update to v0.1.0, first tagged release

    - now we have tags, switch to go:modules fully
    - use REV_OVERRIDE per upstream recommendation to set
        runj --version output

    PR:             275652
    Reported by:    vd
    Sponsored by:   SkunkWerks, GmbH

 sysutils/runj/Makefile                        |   9 +--
 sysutils/runj/Makefile.deps (gone)            |  51 -------------
 sysutils/runj/distinfo                        | 100 ++------------------------
 sysutils/runj/files/patch-REV__OVERRIDE (new) |   4 ++
 4 files changed, 12 insertions(+), 152 deletions(-)
Comment 4 Dave Cottlehuber freebsd_committer freebsd_triage 2024-01-10 15:40:52 UTC
asked upstream nicely and got a tagged release, switch to go modules.