Bug 275671
| Summary: | deskutils/nextcloudclient: Update to 3.11.0 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Guido Falsi <madpilot> | ||||||
| Component: | Individual Port(s) | Assignee: | Michael Reifenberger <mr> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(mr) |
||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Hi, Please hold this, a newer release with some useful improvements is available. I'm working it, I think I'll also be able to reactivate the DOCS option and add KDE and GNOME integration flags. Created attachment 247022 [details]
patch v2
Adding a new patch upgrading to 3.11.0
I also made some more improvements:
- Taking advantage of new cmake option to disable webengine
- Added options to control integration with KDE and GNOME file managers
- Adjusted dependencies, so they more correctly reflect selected options
- Fixed the DOCS option
- Reordered soem variable to adapt to the suggested order (via portclippy)
Hope this can be merged soon!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0195d3d92c72b56528e342106ce7358db29e41a4 commit 0195d3d92c72b56528e342106ce7358db29e41a4 Author: Michael Reifenberger <mr@FreeBSD.org> AuthorDate: 2023-12-16 13:30:33 +0000 Commit: Michael Reifenberger <mr@FreeBSD.org> CommitDate: 2023-12-16 13:34:41 +0000 deskutils/nextcloudclient: Update to 3.11.0 Guido made some additional improvements: - Taking advantage of new cmake option to disable webengine - Added options to control integration with KDE and GNOME file managers - Adjusted dependencies, so they more correctly reflect selected options - Fixed the DOCS option - Reordered some variable to adapt to the suggested order (via portclippy) PR: 275671 Reported by: Guido Falsi deskutils/nextcloudclient/Makefile | 46 +++++++++++++--------- deskutils/nextcloudclient/distinfo | 6 +-- .../nextcloudclient/files/patch-doc_CMakeLists.txt | 4 +- .../files/patch-src_CMakeLists.txt (gone) | 41 ------------------- deskutils/nextcloudclient/pkg-plist | 11 ++++-- 5 files changed, 40 insertions(+), 68 deletions(-) Hi, done. BTW: during a testbuild with poudriere I got: ... =>> Checking for filesystem violations... done =>> Error: Filesystem touched during build: extra: var/db/fontconfig/80dd2d42f425b26d172d5a8554fff72b-le64.cache-8 extra: var/db/fontconfig/d37af3775064ff14b0024d8fdacd5027-le64.cache-8 build of deskutils/nextcloudclient | nextcloudclient-3.11.0 ended at Fri Dec 15 18:08:26 CET 2023 build time: 00:01:39 !!! build failure encountered !!! ... Haven't looked into it, Maybe a fontconfig call somewhere. The bulk build went fine though. Therefore it got committed. Thanks for the Patch! (In reply to Michael Reifenberger from comment #4) Hi, Yes I noticed that too, but I assume that is a false positive. here is the error: =>> Checking for filesystem violations... done =>> Error: Filesystem touched during build: extra: var/db/fontconfig/80dd2d42f425b26d172d5a8554fff72b-le64.cache-8 extra: var/db/fontconfig/d37af3775064ff14b0024d8fdacd5027-le64.cache-8 I'm not sure what the policy is here, these are generated by a program ran during the built and are just cache files. Maybe this directory should be added to the ones poudriere ignores. The port causes various fonts to be installed as dependencies and pkg runs the content of PREFIX/share/pkg/triggers/fontconfig.ucl which does run fc-cache. So I suspect that's generating the cache files. I admit I have no idea how to fix that. |
Created attachment 246949 [details] patch v1 Hi, I have tested a simple update to this new version successfully. Compiles fine in poudriere and works well on my machines. Patch attached. Thanks in advance!