Bug 275691
| Summary: | NanoBSD build broken due to wrong fix | ||
|---|---|---|---|
| Product: | Base System | Reporter: | Wout Decré <wout> |
| Component: | misc | Assignee: | Gleb Smirnoff <glebius> |
| Status: | Closed FIXED | ||
| Severity: | Affects Some People | CC: | jlduran |
| Priority: | --- | Keywords: | regression |
| Version: | 14.0-RELEASE | ||
| Hardware: | Any | ||
| OS: | Any | ||
^Triage: assign to committer of d8c70d6dfb65. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=330089470f56d502c629352b85e11522691e3368 commit 330089470f56d502c629352b85e11522691e3368 Author: Gleb Smirnoff <glebius@FreeBSD.org> AuthorDate: 2023-12-21 18:13:44 +0000 Commit: Gleb Smirnoff <glebius@FreeBSD.org> CommitDate: 2023-12-21 18:13:44 +0000 nanobsd: Fix the fix to a typo Submitted by: jlduran@gmail.com Reviewed by: imp, glebius, emaste PR: 275691 Differential Revision: https://reviews.freebsd.org/D43035 Fixes: d8c70d6dfb65218dd3272b34512083621d3ed46d tools/tools/nanobsd/defaults.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Committed to CURRENT. Thanks! qwerqwe qwerqwe foo bar foo bar Sorry for the spam, was testing a script to interact with Bugzilla. Sorry for the spam, was testing a script to interact with Bugzilla. A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=98bac6fb064ca7536ddb67b845c653b926b699a5 commit 98bac6fb064ca7536ddb67b845c653b926b699a5 Author: Gleb Smirnoff <glebius@FreeBSD.org> AuthorDate: 2023-12-21 18:13:44 +0000 Commit: Gleb Smirnoff <glebius@FreeBSD.org> CommitDate: 2024-01-02 19:05:08 +0000 nanobsd: Fix the fix to a typo Submitted by: jlduran@gmail.com Reviewed by: imp, glebius, emaste PR: 275691 Differential Revision: https://reviews.freebsd.org/D43035 Fixes: d8c70d6dfb65218dd3272b34512083621d3ed46d (cherry picked from commit 330089470f56d502c629352b85e11522691e3368) tools/tools/nanobsd/defaults.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) |
d8c70d6dfb65 fixes a typo that was introduced in cbf64e2dd59c but creates a wrong value for NANO_OBJ. The fix adds an extra } after the first NANO_LAYOUT but this should have been added at the end like so: : ${NANO_OBJ:=/usr/obj/nanobsd.${NANO_NAME}${NANO_LAYOUT:+.${NANO_LAYOUT}}} Otherwise, NANO_OBJ will be: /usr/obj/nanobsd.NANO_NAMENANO_LAYOUT:+.NANO_LAYOUT or /usr/obj/nanobsd.NANO_NAME:+. instead of: /usr/obj/nanobsd.NANO_NAME.NANO_LAYOUT or /usr/obj/nanobsd.NANO_NAME