Bug 275781

Summary:	games/phlipple: App icon is being corrupted by dos2unix
Product:	Ports & Packages	Reporter:	Nathan <ntspam2>
Component:	Individual Port(s)	Assignee:	Dmitry Marakasov <amdmi3>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	makc
Priority:	---	Flags:	bugzilla: maintainer-feedback? (amdmi3)
Version:	Latest
Hardware:	Any
OS:	Any

Description Nathan 2023-12-15 16:04:30 UTC

This port's Makefile includes the USES macro dos2unix, but doesn't set any of the variables DOS2UNIX_FILES, DOS2UNIX_GLOB, or DOS2UNIX_REGEX to limit the files to be converted. This results in a corrupt phlipple.png icon file.
The solution is to add the line "DOS2UNIX_GLOB=  *.c *.fnt *.h" to the Makefile.

Comment 1 Dmitry Marakasov freebsd_committer

2023-12-18 21:01:23 UTC

The change sounds valid. I'm moving right now, so I don't have access to FreeBSD machine atm, so if some other committer is willing to fix this, please do. Otherwise I hope to be able to do it in a few weeks.

Comment 2 commit-hook freebsd_committer

2023-12-27 09:12:28 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=372ab1a7ce7756a7eadbda36cee80c91299019fa

commit 372ab1a7ce7756a7eadbda36cee80c91299019fa
Author:     Max Brazhnikov <makc@FreeBSD.org>
AuthorDate: 2023-12-27 09:10:33 +0000
Commit:     Max Brazhnikov <makc@FreeBSD.org>
CommitDate: 2023-12-27 09:10:33 +0000

    games/phlipple: unbreak after c9e43954f5a1

     Limit dos2unix, as global conversion breaks resource files.
     Update WWW.

    PR:             275781
    Reported by:    Nathan
    Approved by:    amdmi3@ (in advance)

 games/phlipple/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comment 3 Max Brazhnikov freebsd_committer

2023-12-27 09:13:18 UTC

Fixed, thanks for report!