Bug 275846

Summary: multimedia/mplayer: Use ffmpeg6 instead of ffmpeg4
Product: Ports & Packages Reporter: Thomas Zander <riggs>
Component: Individual Port(s)Assignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Many People CC: diizzy, george
Priority: --- Flags: riggs: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for the mplayer port to use ffmpeg6 none

Description Thomas Zander freebsd_committer freebsd_triage 2023-12-19 22:15:05 UTC 
Created attachment 247164 [details]
Patch for the mplayer port to use ffmpeg6

Following a mail thread with Mikhail, let's revisit bug #270569 and see if mplayer can move to using ffmpeg6. Initial tests on both Mikhail's and my machines indicate the initial issues are overcome. It would be helpful if few additional folks could test the patch.
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2023-12-19 22:18:34 UTC 
George, Daniel, could you give the attached patch a go?
Comment 2 George Mitchell 2023-12-19 23:09:41 UTC 
The patch applies and the package builds; however, the resulting binary crashes immediately upon trying to play a movie:

MPlayer interrupted by signal 11 in module: demux_open
- MPlayer crashed by bad usage of CPU/FPU/RAM.
  Recompile MPlayer with --enable-debug and make a 'gdb' backtrace and
  disassembly. Details in DOCS/HTML/en/bugreports_what.html#bugreports_crash.
- MPlayer crashed. This shouldn't happen.
  It can be a bug in the MPlayer code _or_ in your drivers _or_ in your
  gcc version. If you think it's MPlayer's fault, please read
  DOCS/HTML/en/bugreports.html and follow the instructions there. We can't and
  won't help unless you provide this information when reporting a possible bug.

I suppose I could get a backtrace, but probably not until late tomorrow.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-12-21 01:40:34 UTC 
Seems to work with various formats on my dev box however I've only tested headless output (14.0, amd64).

mplayer -benchmark -nosound -vo null filename.foo

Best regards,
Daniel
Comment 4 Thomas Zander freebsd_committer freebsd_triage 2024-10-02 20:19:39 UTC 
I have a package in test that I am fairly happy with so far. Plan is to land it after 2024Q4 has branched.
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-10-12 08:03:57 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=adcaaf9898e15c1f760a9a1d448348d75f6c5a3d

commit adcaaf9898e15c1f760a9a1d448348d75f6c5a3d
Author:     Thomas Zander <riggs@FreeBSD.org>
AuthorDate: 2024-09-29 16:27:26 +0000
Commit:     Thomas Zander <riggs@FreeBSD.org>
CommitDate: 2024-10-12 08:03:48 +0000

    multimedia/{mplayer|mencoder}: Update to new upstream snapshot

    Details:
    - Move to upstream snapshot as of 2024-09-28
    - Use ffmpeg6+ instead of ffmpeg4

    PR:             275846

 multimedia/mencoder/distinfo                       |  6 +--
 multimedia/mplayer/Makefile                        |  2 +-
 multimedia/mplayer/Makefile.common                 | 11 ++---
 multimedia/mplayer/Makefile.optvars                |  3 --
 multimedia/mplayer/distinfo                        |  6 +--
 multimedia/mplayer/files/patch-Makefile            | 10 ++---
 multimedia/mplayer/files/patch-configure           | 50 +++++++++-------------
 .../files/patch-libmpcodecs_vd__ffmpeg.c (gone)    | 11 -----
 8 files changed, 35 insertions(+), 64 deletions(-)