Bug 276062

Summary: devel/mongo-c-driver: Use USE_GITHUB helper and always use (lib)utf8proc from ports
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Daniel Engberg <diizzy>
Status: Closed FIXED    
Severity: Affects Only Me CC: ports
Priority: --- Flags: ports: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for mongo-c-driver none

Description Daniel Engberg freebsd_committer freebsd_triage 2024-01-01 20:55:40 UTC 
Created attachment 247395 [details]
Patch for mongo-c-driver

* Use USE_GITHUB helper instead of working around it
* Always unbundle (lib)utf8proc as per Porters Handbook
* Partially fix USES= pathfix

References:
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github
https://docs.freebsd.org/en/books/porters-handbook/book/#bundled-libs-practices
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-01-01 20:57:01 UTC 
https://github.com/mongodb/mongo-c-driver/blob/master/build/cmake/GeneratePkgConfig.cmake needs a patch or preferably a patch submitted upstream to install .pc files into libdata
Comment 2 Krzysztof 2024-01-02 11:57:28 UTC 
Comment on attachment 247395 [details]
Patch for mongo-c-driver

OK. I've tried to change Makefile to use "GH_*" variables but I have failed. Probably I've made a mistake somewhere..

I approve this patch.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-01-03 19:52:37 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=474a16b79d35866ad09a29454ef26fb7bd2cd841

commit 474a16b79d35866ad09a29454ef26fb7bd2cd841
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-01-03 19:48:00 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-01-03 19:52:14 +0000

    devel/mongo-c-driver: Use USE_GITHUB helper and always use (lib)utf8proc from ports

    * Use USE_GITHUB helper instead of working around it
    * Always unbundle (lib)utf8proc as per Porters Handbook
    * Partially fix USES= pathfix

    PR:             276062
    Reviewed by:    Krzysztof <ports@bsdserwis.com> (maintainer)

 devel/mongo-c-driver/Makefile | 18 ++++++++++--------
 devel/mongo-c-driver/distinfo |  6 +++---
 2 files changed, 13 insertions(+), 11 deletions(-)