Bug 276140

Summary: devel/luv: Use upstream release archive
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Adam Weinberger <adamw>
Status: Closed FIXED    
Severity: Affects Only Me Flags: adamw: maintainer-feedback+
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for luv none

Description Daniel Engberg freebsd_committer freebsd_triage 2024-01-06 07:48:25 UTC
Created attachment 247475 [details]
Patch for luv

Use upstream release archive as recommened by Porters Handbook
Examples are not included in dist file

Compile and runtime tested on FreeBSD 14.0-RELEASE (amd64) (make, make check-plist)

Poudriere testport OK 14.0-RELEASE (amd64)
Poudriere testport OK 13.2-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-01-10 06:13:04 UTC
Friendly ping
Comment 2 Adam Weinberger freebsd_committer freebsd_triage 2024-01-10 11:57:10 UTC
I’m not particularly into the idea of switching to upstream archives for the sake of switching to upstream archives, but I really like how much this simplifies the Makefile.

Can you commit this please?
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-01-13 08:25:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ef802637ea6ceebe9464fdca7e42b48c093943b6

commit ef802637ea6ceebe9464fdca7e42b48c093943b6
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-01-13 08:13:04 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-01-13 08:24:29 +0000

    devel/luv: Switch to upstream release archive

    * Use upstream release archive as recommened by Porters Handbook and
      also simplifies Makefile
    * Remove EXAMPLES options as example files are not included

    PR:             276140
    Reviewed by:    adamw (maintainer)

 devel/luv/Makefile | 14 ++------------
 devel/luv/distinfo |  8 +++-----
 2 files changed, 5 insertions(+), 17 deletions(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-01-13 08:26:16 UTC
Committed, thanks!