Bug 276231
| Summary: | devel/py-threadpoolctl: Mark broken on 13.2-RELEASE and earlier, add pytest | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jason W. Bacon <jwb> |
| Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> |
| Status: | Closed FIXED | ||
| Severity: | Affects Some People | Flags: | bugzilla:
maintainer-feedback?
(sunpoet) |
| Priority: | --- | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
IGNORE might be better than BROKEN, if this is not going to be patched. Since 13.3 is released, it is OK to commit this patch. Otherwise it would block some ports in a 13.2-RELEASE poudriere jail. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=6fe6ac2e17648da3bc204470b67ea847cfe2cb43 commit 6fe6ac2e17648da3bc204470b67ea847cfe2cb43 Author: Jason W. Bacon <jwb@freebsd.org> AuthorDate: 2024-03-09 13:57:35 +0000 Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> CommitDate: 2024-03-09 14:07:23 +0000 devel/py-threadpoolctl: Mark IGNORE for FreeBSD 13.2-RELEASE PR: 276231 devel/py-threadpoolctl/Makefile | 6 ++++++ 1 file changed, 6 insertions(+) Committed. Thanks! |
py-threadpoolctl does not function properly on 13.2-RELEASE and earlier due to improper handling on dynamically loaded libc. FreeBSD 13-STABLE and 14 are patched to handle the code correctly. Suggest something like the following: .include <bsd.port.options.mk> .if ${OPSYS} == FreeBSD && ${OSVERSION} < 1302509 BROKEN= Does not run on FreeBSD 13.2 or earlier due to handling of dynamically loaded libc .endif Note: 1302509 is a later commit than the one with the fix, but it should be fine as nobody is likely depending on an earlier 13-STABLE. Reference: https://github.com/joblib/threadpoolctl/pull/148#discussion_r1446329259 Also, adding USE_PYTHON=pytest seems sufficient to enable "make test".