Bug 276359
| Summary: | security/py-flask-saml: Update to 0.5.1 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John W. O'Brien <john> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | python, wen | ||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=2e26811c8c2ca2c8067f975767cadb2b881c026f commit 2e26811c8c2ca2c8067f975767cadb2b881c026f Author: Wen Heping <wen@FreeBSD.org> AuthorDate: 2024-01-19 03:24:53 +0000 Commit: Wen Heping <wen@FreeBSD.org> CommitDate: 2024-01-19 03:25:47 +0000 security/py-flask-saml: Update to 0.5.1 PR: 276359 Reported by: maintainer security/py-flask-saml/Makefile | 7 +++---- security/py-flask-saml/distinfo | 6 +++--- 2 files changed, 6 insertions(+), 7 deletions(-) (In reply to commit-hook from comment #1) Thanks for taking this, Wen. It looks like the commit that landed is a little different than the patch I prepared when it comes to security/py-pysaml* in RUN_DEPENDS. I'm inclined to believe this was a mistake, since "pysaml24>=6.5.0<5" is self-evidently unsatisfiable. .if ${PYTHON_REL} < 30900 RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}pysaml26>=6.5.0:security/py-pysaml26@${PY_FLAVOR} .else RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}pysaml2>=6.5.0:security/py-pysaml2@${PY_FLAVOR} .endif Flask-SAML itself claims support for Python 3.8 or higher. PySAML, on the other hand, dropped support for 3.8 as of 7.4.0. security/py-pysaml26 still satisfies the ">=6.5.0" dependency and supports 3.8. What's your perspective? Wen, this port is failing run-depends with py38, which I think is avoidable. Could you please respond to comment #2? (In reply to John W. O'Brien from comment #3) Sorry for the delay. It is my fault. I shall update it as your patch. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5f993c18c21e1c49834414a966c20d5fb712161b commit 5f993c18c21e1c49834414a966c20d5fb712161b Author: Wen Heping <wen@FreeBSD.org> AuthorDate: 2024-02-05 01:24:44 +0000 Commit: Wen Heping <wen@FreeBSD.org> CommitDate: 2024-02-05 01:26:23 +0000 security/py-flask-saml: Fix typo in previous commit PR: 276359 Reported by: john@saltant.com(maintainer) security/py-flask-saml/Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (In reply to Wen Heping from comment #4) Thanks, Wen. It doesn't look like I have a way to assign this bug to you for resolution. (In reply to John W. O'Brien from comment #6) No problem. Would you close the PR if all is OK ? (In reply to Wen Heping from comment #7) This port is still failing in run-depends with py38. From my patch: .if ${PYTHON_REL} < 30900 RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}pysaml26>=6.5.0:security/py-pysaml26@${PY_FLAVOR} .else RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}pysaml2>=6.5.0:security/py-pysaml2@${PY_FLAVOR} .endif After your last commit: .if ${PYTHON_REL} < 30900 RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}pysaml24>=6.5.0:security/py-pysaml24@${PY_FLAVOR} .else RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}pysaml26>=6.5.0:security/py-pysaml26@${PY_FLAVOR} .endif A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=2a70b63721df5009c22985b80df8431d33c620b8 commit 2a70b63721df5009c22985b80df8431d33c620b8 Author: Wen Heping <wen@FreeBSD.org> AuthorDate: 2024-02-07 12:16:16 +0000 Commit: Wen Heping <wen@FreeBSD.org> CommitDate: 2024-02-07 12:17:27 +0000 security/py-flask-saml: Correct EUN_DEPENDS PR: 276359 Reported by: john@saltant.com(maintainer) security/py-flask-saml/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) |
Created attachment 247690 [details] security/py-flask-saml: Update to 0.5.1 Changelog ========= * Update to 0.5.1 QA == portlint: OK poudriere: OK -- testport on 13.2-RELEASE amd64 w/py38, py39, py310 (default), and py311