Bug 276380

Summary: security/py-pysha3: limit python version and possibly deprecate port
Product: Ports & Packages Reporter: Ruslan Makhmatkhanov <rm>
Component: Individual Port(s)Assignee: Muhammad Moinur Rahman <bofh>
Status: Closed FIXED    
Severity: Affects Only Me CC: rm
Priority: --- Flags: bugzilla: maintainer-feedback? (bofh)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 275494    
Attachments:
Description Flags
deprecate patch none

Description Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2024-01-16 17:06:55 UTC
Created attachment 247707 [details]
deprecate patch

According to pysha github page: [1]:
```
The pysha3 package has reached its end of life and is no longer supported.

The SHA-3 code was merged into Python 3.6 many years ago. Please use SHA-3 functions from hashlib module directly.
```

so this port is only applicable for python2.7-3.4, so I'd prefer to mark it so in USES section. 

This is a showstopper for switching to python3.11 (PR 275494)
Comment 1 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2024-01-16 17:07:29 UTC
[1] https://github.com/tiran/pysha3
Comment 2 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2024-01-16 17:09:24 UTC
I wish I could just delete this. :/
Comment 3 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2024-01-16 17:26:16 UTC
I think your patch is wrong. It should not be python:3.6- but python:-3.6.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-01-16 17:48:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=da7ccecae72d64dc75087744164b6d9f1a8c6878

commit da7ccecae72d64dc75087744164b6d9f1a8c6878
Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
AuthorDate: 2024-01-16 17:20:28 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2024-01-16 17:47:41 +0000

    security/py-pysha3: Mark DEPRECATED

    - Mark to IGNORE for 3.9 and later
    - These library has been merged into python 3.6
    - Upstream has declared abandoned
    - Set EXPIRATION_DATE 2024-02-16

    PR:             276380

 security/py-pysha3/Makefile | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
Comment 5 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2024-01-16 18:12:05 UTC
(In reply to Muhammad Moinur Rahman from comment #3)

yes, you are right, sorry. Thanks!