Bug 276473
| Summary: | graphics/imlib2: enable JPEG XL by default | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jan Beich <jbeich> | ||||
| Component: | Individual Port(s) | Assignee: | Nuno Teixeira <eduardo> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(eduardo) |
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | 276369 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
On landing PORTREVISION must be bumped. I don't want to reupload the diff for such a minor change. imlib2/WEBP=on vs. imlib2-webp and imlib2/JXL=on vs. imlib2-jxl can be improved via SUBPACKAGES. Alternatively, imlib2-webp and imlib2-jxl can be removed from ports/ tree. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=6c7466cb7f3c9d5e52f356847bf0ee8cbb619252 commit 6c7466cb7f3c9d5e52f356847bf0ee8cbb619252 Author: Jan Beich <jbeich@FreeBSD.org> AuthorDate: 2024-01-20 16:09:48 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2024-01-20 16:09:48 +0000 graphics/imlib2: enable JPEG XL by default Already default upstream via auto-detection. Adjust conflicts per options. PR: 276473 graphics/imlib2/Makefile | 12 ++++++++---- graphics/imlib2/pkg-plist | 1 + 2 files changed, 9 insertions(+), 4 deletions(-) (In reply to Jan Beich from comment #1) Nice catch. SUBPACKAGES have been discussed on element chat. Will work on it and open a review soon. Committed, thank you! |
Created attachment 247797 [details] v1 (apply via "git am") Already default upstream via auto-detection e.g., $ pkg install libjxl $ export DEVELOPER=1 || setenv DEVELOPER 1 $ make clean all -C graphics/imlib2 [...] ====> Running Q/A tests (stage-qa) Error: /usr/local/lib/imlib2/loaders/jxl.so is linked to /usr/local/lib/libjxl.so.0.9 from graphics/libjxl but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libjxl.so:graphics/libjxl Error: /usr/local/lib/imlib2/loaders/jxl.so is linked to /usr/local/lib/libjxl_threads.so.0.9 from graphics/libjxl but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libjxl_threads.so:graphics/libjxl