Bug 276490

Summary: databases/p5-SQL-Abstract-More: Update to 1.43
Product: Ports & Packages Reporter: Sergei Vyshenski <svysh.fbsd>
Component: Individual Port(s)Assignee: Zsolt Udvari <uzsolt>
Status: Closed FIXED    
Severity: Affects Only Me CC: svysh.fbsd, uzsolt
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://metacpan.org/changes/distribution/SQL-Abstract-More
Attachments:
Description Flags
git format-patch -1 main
svysh.fbsd: maintainer-approval+
git format-patch -1 main
svysh.fbsd: maintainer-approval+
git format-patch -1 main svysh.fbsd: maintainer-approval+

Description Sergei Vyshenski 2024-01-21 10:26:09 UTC
Created attachment 247811 [details]
git format-patch -1 main

- update 1.40 -> 1.41

ChangeLog: https://metacpan.org/changes/distribution/SQL-Abstract-More

- "portlint -AC" is happy.
- "portclippy Makefile" is happy.
- "portfmt -D Makefile" is happy.
- Tested with:
14.0-RELEASE-p4
portlint 2.22.0
portfmt 1.1.5
pkg 1.20.990.8
poudriere-git-3.4.99.20240105
perl 5.36.3_1
openssl 3.0.12
ssl=base
- built-in perl tests in a clean poudriere jail say: PASS.
Comment 1 Sergei Vyshenski 2024-01-23 06:43:30 UTC
Created attachment 247867 [details]
git format-patch -1 main

- update 1.40 -> 1.42

ChangeLog: https://metacpan.org/changes/distribution/SQL-Abstract-More

- "portlint -AC" is happy.
- "portclippy Makefile" is happy.
- "portfmt -D Makefile" is happy.
- Tested with:
14.0-RELEASE-p4
portlint 2.22.0
portfmt 1.1.5
pkg 1.20.990.8
poudriere-git-3.4.99.20240122
perl 5.36.3_1
openssl 3.0.12
ssl=base
- built-in perl tests in a clean poudriere jail say: PASS.
Comment 2 Sergei Vyshenski 2024-03-06 10:25:49 UTC
Created attachment 248966 [details]
git format-patch -1 main

databases/p5-SQL-Abstract-More: Update to 1.43

- update 1.40 -> 1.43

ChangeLog: https://metacpan.org/changes/distribution/SQL-Abstract-More

- "portlint -AC" is happy.
- "portclippy Makefile" is happy.
- "portfmt -D Makefile" is happy.
- Tested with:
14.0-RELEASE-p5
portlint 2.22.0
portfmt 1.1.5
pkg 1.20.99.9
poudriere-git-3.4.99.20240122_1
perl 5.36.3_1
openssl 3.0.12
ssl=base
- built-in perl tests in a clean poudriere jail say: PASS.
Comment 3 Sergei Vyshenski 2024-05-13 10:52:21 UTC
Zsolt,

Please let me know if and how I can help with this PR.

Regards, Sergei
Comment 4 Zsolt Udvari freebsd_committer freebsd_triage 2024-05-13 18:05:16 UTC
Waiting for approval:
https://reviews.freebsd.org/D44574
I don't understand diizzy's comment because I can build it.
Comment 5 Sergei Vyshenski 2024-05-13 20:19:23 UTC
Zsolt,

Most probably there is a misunderstanding.

1. Consider 3 ports (as it happens, I maintain of all of them), mentioned by diizzy:

port A: security/p5-openxpki
port B: security/p5-openxpki-i18n
port C: databases/p5-SQL-Abstract-More (which is the port being considered in this PR).

If port X depends (directly or indirectly) from port Y, let us designate this dependency with symbolic expressions as: "X -> Y" or "Y <- X". 

Then dependencies between 3 mentioned ports are as follows:

B <- A -> C

This symbolic expression is evident from looking at the page:

https://ports.freebsd.org/cgi/ports.cgi?query=xpki&stype=all&sektion=all

That is, our port C (being considered here) is needed to build port A. But ports A and B are irrelevant for building of port C.

2. On my box I can build all of 3 ports just fine:
14.0-RELEASE-p6
portlint 2.22.1
portfmt 1.1.5
pkg 1.21.99.1
poudriere-git-3.4.99.20240424
perl 5.36.3_1
openssl 3.0.12 

3. Actually at the moment I am waiting for you to commit this PR with update for port C. It is needed for me to submit a new version of port A with major update.

Hope this helps.
Regards, Sergei Vyshenski
Comment 6 Sergei Vyshenski 2024-05-14 07:20:24 UTC
Oh, it seems that I am beginning to understand the meaning of Daniel's comment.

Port security/p5-openxpki-i18n (referred to as port B above) fails to build after recent updates to gettext.

This failure happens with or without applying a patch for port databases/p5-SQL-Abstract-More, proposed here.

Let me investigate further.

Thank you so much for the alert.
Regards, Sergei
Comment 7 Sergei Vyshenski 2024-05-14 10:51:43 UTC
Blinking failure of build for port security/p5-openxpki-i18n goes away altogether, if I add a line:

MAKE_JOBS_UNSAFE= yes

to the Makefile of port security/p5-openxpki-i18n, just under the line:

USE_GITHUB= yes

And again, my tests show, that this blinking problem manifests itself irrespective of applying or not applying the patch (under discussion here) for the port databases/p5-SQL-Abstract-More. I will submit a major stable update of ports security/p5-openxpki{-i18n}, which will address this issue. Hopefully very soon. But IMHO, port databases/p5-SQL-Abstract-More could be updated right away (with the present patch), irrespective of that future major update.
Comment 8 Sergei Vyshenski 2024-05-19 20:23:25 UTC
Zsolt,

Not sure how email notification of https://reviews.freebsd.org/D44574 works.
Have you noticed that diizzy approved the case?
Please let me know if I can be of further help.

Regards, Sergei
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-05-20 18:36:58 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6de0c30f60f9c1c96d7b37af2e2d49f66766003c

commit 6de0c30f60f9c1c96d7b37af2e2d49f66766003c
Author:     Sergei Vyshenski <svysh.fbsd@gmail.com>
AuthorDate: 2024-05-13 18:16:59 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-05-20 18:34:51 +0000

    databases/p5-SQL-Abstract-More: update to 1.43

    Changelog: https://metacpan.org/dist/SQL-Abstract-More/changes

    PR:             276490
    Approved by:    submitter is maintainer, diizzy (mentor)
    Differential Revision:  https://reviews.freebsd.org/D44574

 databases/p5-SQL-Abstract-More/Makefile | 2 +-
 databases/p5-SQL-Abstract-More/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 10 Zsolt Udvari freebsd_committer freebsd_triage 2024-05-20 18:37:40 UTC
Committed, thanks!