Bug 276580

Summary: security/nmap: obey NLS option for non-English manpages
Product: Ports & Packages Reporter: Helge Oldach <freebsd>
Component: Individual Port(s)Assignee: Cy Schubert <cy>
Status: Closed FIXED    
Severity: Affects Many People CC: freebsd
Priority: --- Flags: bugzilla: maintainer-feedback? (cy)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Helge Oldach 2024-01-24 08:28:49 UTC
Created attachment 247916 [details]
patch

nmap ./configure obeys --disable-nls / --enable-nls so it's straightforward to tweak install of non-Englisch manpages.
Comment 1 Cy Schubert freebsd_committer freebsd_triage 2024-01-24 09:27:30 UTC
Default will be NLS on.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-01-24 09:38:06 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d7c24e0f57125b5be6533f4dc1618288d2ad40f0

commit d7c24e0f57125b5be6533f4dc1618288d2ad40f0
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2024-01-24 09:33:46 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2024-01-24 09:33:46 +0000

    security/nmap: Add NLS option

    Add a (default) NLS option.

    PR:             276580
    Original by:    Helge Oldach <freebsd@oldach.net>
    MFH:            2024Q1

 security/nmap/Makefile  |  7 ++++---
 security/nmap/pkg-plist | 28 ++++++++++++++--------------
 2 files changed, 18 insertions(+), 17 deletions(-)
Comment 3 Helge Oldach 2024-01-24 09:39:37 UTC
(In reply to Cy Schubert from comment #1)
Indeed, NLS on is the global default, which is why it's not explicitely set in OPTIONS_DEFAULT.
Comment 4 Cy Schubert freebsd_committer freebsd_triage 2024-01-24 09:43:46 UTC
(In reply to Helge Oldach from comment #3)
I like to specify it anyway.
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-01-24 09:51:08 UTC
A commit in branch 2024Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ef3384d24e58290a29166010a768eac687cb4e88

commit ef3384d24e58290a29166010a768eac687cb4e88
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2024-01-24 09:33:46 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2024-01-24 09:50:07 +0000

    security/nmap: Add NLS option

    Add a (default) NLS option.

    PR:             276580
    Original by:    Helge Oldach <freebsd@oldach.net>

    (cherry picked from commit d7c24e0f57125b5be6533f4dc1618288d2ad40f0)

 security/nmap/Makefile  |  6 ++++--
 security/nmap/pkg-plist | 28 ++++++++++++++--------------
 2 files changed, 18 insertions(+), 16 deletions(-)
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2024-02-08 02:59:49 UTC
^Triage: committed and MFQed.