Bug 276591

Summary: devel/electron25, devel/electron26, devel/electron27 fail to check LIB_DEPENDS if HEIMDAL option is selected.
Product: Ports & Packages Reporter: Yasuhito FUTATSUKI <freebsd-bug-report-yf>
Component: Individual Port(s)Assignee: Hiroki Tagato <tagattie>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (tagattie)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   

Description Yasuhito FUTATSUKI 2024-01-24 15:44:26 UTC 
With ports options:

OPTIONS_FILE_SET+=KERBEROS
OPTIONS_FILE_SET+=HEIMDAL
OPTIONS_FILE_UNSET+=HEIMDAL_BASE
OPTIONS_FILE_UNSET+=MIT

poudriere bulk fails to build electron25 such as:
[[[
...
[14amd64-local-desktop-job-01] Extracting cups-2.4.7_1: .......... done
===>   electron25-25.9.8_2 depends on shared library: libcups.so - found (/usr/local/lib/libcups.so)
===>   Returning to build of electron25-25.9.8_2
===>   electron25-25.9.8_2 depends on shared library: libkrb.so.26 - not found
===>   Installing existing package /packages/All/heimdal-7.8.0_6.pkg
[14amd64-local-desktop-job-01] Installing heimdal-7.8.0_6...
the most recent version of heimdal-7.8.0_6 is already installed
===>   electron25-25.9.8_2 depends on shared library: libkrb.so.26 - not found
*** Error code 1

Stop.
]]]

It seems this is caused by the typo in Makefile
[[[
diff --git a/devel/electron25/Makefile b/devel/electron25/Makefile
index d4947e548c28..4ccef77a42f1 100644
--- a/devel/electron25/Makefile
+++ b/devel/electron25/Makefile
@@ -188,7 +188,7 @@ DEBUG_VARS_OFF=             BUILDTYPE=Release \
 DIST_IMPLIES=          DRIVER
 DRIVER_MAKE_ARGS=      chromedriver
 
-HEIMDAL_LIB_DEPENDS=   libkrb.so.26:security/heimdal
+HEIMDAL_LIB_DEPENDS=   libkrb5.so.26:security/heimdal
 KERBEROS_VARS=         GN_ARGS+=use_kerberos=true
 KERBEROS_VARS_OFF=     GN_ARGS+=use_kerberos=false
 
]]]
... and also it might be applied in electron26, electron27.

I'm not sure we can build it even with the change above, I'm just trying (it takes 1 day).
Comment 1 Hiroki Tagato freebsd_committer freebsd_triage 2024-01-25 08:19:51 UTC 
(In reply to Yasuhito FUTATSUKI from comment #0)

Hi Yasuhito-san,

Thanks for spotting the error. This is indeed a typo.
I will update electron25, electron26, and electron27 soon.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-01-25 11:03:39 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c91b0eb1f6081ca808008fbcfe0a14a38010c5fd

commit c91b0eb1f6081ca808008fbcfe0a14a38010c5fd
Author:     Hiroki Tagato <tagattie@FreeBSD.org>
AuthorDate: 2024-01-25 11:00:03 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2024-01-25 11:02:40 +0000

    devel/electron{25,26,27}: fix build when HEIMDAL or MIT option is ON

    PR:             276591
    Reported by:    Yasuhito FUTATSUKI <freebsd-bug-report-yf@yf.bsdclub.org>
    MFH:            2024Q1

 devel/electron25/Makefile | 4 ++--
 devel/electron26/Makefile | 4 ++--
 devel/electron27/Makefile | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-01-25 11:04:41 UTC 
A commit in branch 2024Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=960185c746dc2649191c78f6fbe7307905a84b6c

commit 960185c746dc2649191c78f6fbe7307905a84b6c
Author:     Hiroki Tagato <tagattie@FreeBSD.org>
AuthorDate: 2024-01-25 11:00:03 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2024-01-25 11:04:19 +0000

    devel/electron{25,26,27}: fix build when HEIMDAL or MIT option is ON

    PR:             276591
    Reported by:    Yasuhito FUTATSUKI <freebsd-bug-report-yf@yf.bsdclub.org>
    MFH:            2024Q1

    (cherry picked from commit c91b0eb1f6081ca808008fbcfe0a14a38010c5fd)

 devel/electron25/Makefile | 4 ++--
 devel/electron26/Makefile | 4 ++--
 devel/electron27/Makefile | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)
Comment 4 Hiroki Tagato freebsd_committer freebsd_triage 2024-01-25 11:05:28 UTC 
Committed, thanks!