Bug 276726
| Summary: | net/widentd: updates, new MASTERSITE on VCS now encouraging public review | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Chris Hutchinson <portmaster> | ||||||||
| Component: | Individual Port(s) | Assignee: | Gleb Popov <arrowd> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | arrowd, diizzy | ||||||||
| Priority: | --- | Keywords: | easy | ||||||||
| Version: | Latest | Flags: | portmaster:
maintainer-feedback+
|
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Use https://codeberg.org/${ACCOUNTNAME}/${PROJECTNAME}/archive/${DISTVERSIONFULL}${EXTRACT_SUFX}?dummy=/ What's the reason to keep this in (already dropped all other distros)? (In reply to Daniel Engberg from comment #1) Why use FreeBSD, when Linux is so much more popular? I can't speak for other distros. Not sure it even applies. But it works well and as intended. Now that it's on a public VCS. Others can suggest/add improvements and/or features. Besides, who doesn't like choices? :) Thanks. --Chris (In reply to Daniel Engberg from comment #1) > https://codeberg.org/${ACCOUNTNAME}/${PROJECTNAME}/archive/${DISTVERSIONFULL}${EXTRACT_SUFX}?dummy=/ I'll check that out and update the patch. Thanks, again. Created attachment 248128 [details] updated patch for net/widentd (version 2) Here's an update that's as close as I can get to your recommendation. Your recommendation as it was failed as follows: # make -DBATCH makesum ===> License BSD3CLAUSE accepted by the user ===> License BSD3CLAUSE accepted by the user ===> widentd-1.05 depends on file: /usr/local/sbin/pkg - found => widentd-1.05.tar.gz doesn't seem to exist in /usr/ports/distfiles/. => Attempting to fetch https://codeberg.org/BSDforge/widentd/archive/1.05.tar.gz?dummy=/widentd-1.05.tar.gz fetch: https://codeberg.org/BSDforge/widentd/archive/1.05.tar.gz?dummy=/widentd-1.05.tar.gz: Not Found => Attempting to fetch http://distcache.FreeBSD.org/ports-distfiles/widentd-1.05.tar.gz fetch: http://distcache.FreeBSD.org/ports-distfiles/widentd-1.05.tar.gz: Not Found => Couldn't fetch it - please try to retrieve this => port manually into /usr/ports/distfiles/ and try again. *** Error code 1 --Chris (In reply to Daniel Engberg from comment #1) Just performed a count of installs for this port for the month of January; grep widentd-1.04.tar.xz /path/to/bsdwatch/access/log | grep libfetch | grep -Eiv '(freebsd)' | awk '{print $1}' | uniq | wc -l 71 71. Not too bad for an old port? ;) Just thought it worth mentioning. Probably even better in the future, now that it's in a public VCS? The
${MV} ${WRKDIR}/widentd ${WRKDIR}/widentd-1.05
hack should be replaced with setting WRKSRC knob.
Created attachment 248863 [details]
patch against net/widentd (version 3)
patch to (hopefully) address your comment about the WRKSRC hack.
I used:
${MV} ${WRKDIR}/${PORTNAME} ${WRKDIR}/${PORTNAME}-${DISTVERSION}
I required it only as USE_RC_SUBR gets confused over the WRK(DIR|SRC)
paradigm.
That's (hopefully) it. :)
Thanks for all your time and efforts here!
--Chris
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1704b36b05603fa914bdcf17fc967958e57ada76 commit 1704b36b05603fa914bdcf17fc967958e57ada76 Author: Chris Hutchinson <portmaster@bsdforge.com> AuthorDate: 2024-03-02 11:45:12 +0000 Commit: Gleb Popov <arrowd@FreeBSD.org> CommitDate: 2024-03-02 11:45:12 +0000 net/widentd: Update to 1.05 PR: 276726 net/widentd/Makefile | 26 +++++++++++++++++--------- net/widentd/distinfo | 5 +++-- 2 files changed, 20 insertions(+), 11 deletions(-) |
Created attachment 248074 [details] patch for net/widentd The attached patch updates net/widentd. This program worked without problems. But was DEPRECIATED for lack of activity. As this program worked flawlessly. It seemed prudent to move this to a public VCS to encourage public review and promote improvements that otherwise may not have occurred. CHANGES Makefile distinfo files/patch-widentd.c That's it, thanks! --Chris