Summary: | sysutils/vmstated: Update to 0.10 | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Chris Moerz <freebsd> | ||||||||||||||||||
Component: | Individual Port(s) | Assignee: | Robert Clausecker <fuz> | ||||||||||||||||||
Status: | Closed FIXED | ||||||||||||||||||||
Severity: | Affects Only Me | CC: | fernape, fuz | ||||||||||||||||||
Priority: | --- | Flags: | freebsd:
maintainer-feedback+
|
||||||||||||||||||
Version: | Latest | ||||||||||||||||||||
Hardware: | Any | ||||||||||||||||||||
OS: | Any | ||||||||||||||||||||
URL: | https://github.com/christian-moerz/vmstated/releases/tag/0.07 | ||||||||||||||||||||
Attachments: |
|
Created attachment 248135 [details]
poudriere log for 13.2-RELEASE
^Triage: [tags] in issue Titles are deprecated. ^Triage: Simplifying title ^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field. ^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval. -- Attachment -> Details -> maintainer-approval [+] Thanks! Adding change log URL - https://github.com/christian-moerz/vmstated/releases/tag/0.05 Created attachment 248362 [details] Patch to version 0.07 Update replaces previous patch due to upstream version bump Additional bug fixes - creates log directory if it does not exist - now returns useful error message when unkonwn vm name is used - supports returning custom short codes and messages in libsocket WWW: https://github.com/christian-moerz/vmstated/releases/tag/0.07 Created attachment 248363 [details]
poudriere log for 13.2-RELEASE
Updated poudriere log for version 0.07
Damn, just realized I forgot to limit the architecture in the new Makefile patch. Will update again in a moment... Created attachment 248364 [details]
Patch to version 0.07
Included architecture limitation now as well.
Created attachment 248365 [details]
poudriere log for 13.2-RELEASE
Ran with updated Makefile; portlint and portclippy are happy...
Is there anything I can do to move this forward? I'm wondering if anything might be missing or wrong since I haven't gotten any feedback for more than a month? Any feedback appreciated! Thanks! Sorry for the late response. Could you tell me why this port should only be available for aarch64, amd64, and armv7? Does it only work on these architectures? What about other architectures, such as riscv64? If it just doesn't work on i386, set NOT_FOR_ARCHS instead of ONLY_FOR_ARCHS. By defaults, ports should be built for all architectures, unless known not to work. In any case, make sure to also set NOT_FOR_ARCHS_REASON or ONLY_FOR_ARCHS_REASON. Patch looks ok otherwise. Created attachment 250549 [details]
patch for sysutils/vmstated update to 0.10
Updated patch for version 0.10, including exclusion of i386 architecture as suggested.
Thanks! Appreciate the feedback on the previous update!
Created attachment 250550 [details]
poudriere log for 13.3-RELEASE-p2
(In reply to Robert Clausecker from comment #10) Thanks for the feedback - I've changed the Makefile to reflect the limitations in architecture. i386 is now excluded, because - pie does not work/compile - bhyve unlikely to be applied on non-64bit systems; I was told bhyve does not work on i386 during the production user's calls but couldn't really find anything in the documentation to confirm or contradict that... Thanks (In reply to Chris Moerz from comment #13) Thank you for the update. I didn't realise that this tool needs bhyve to work. In this case I think it'll be ok to limit the port to just arm64 and amd64 as these are the only ones for which bhyve exists right now. Will commit this one with my next batch (this may take a week or so). A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=87a0d1e107d4d7dbb9ee752a62a93452f7c36258 commit 87a0d1e107d4d7dbb9ee752a62a93452f7c36258 Author: Chris Moerz <freebsd@ny-central.org> AuthorDate: 2024-05-09 14:23:24 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2024-05-13 21:18:55 +0000 sysutils/vmstated: Update to 0.10 - only for aarch64/amd64, as this tool doesn't make much sense in the absence of bhyve Changelog: https://github.com/christian-moerz/vmstated/releases/tag/0.10 PR: 276778 sysutils/vmstated/Makefile | 10 ++++------ sysutils/vmstated/distinfo | 6 +++--- sysutils/vmstated/pkg-plist | 4 ++++ 3 files changed, 11 insertions(+), 9 deletions(-) Thank you for your contribution. |
Created attachment 248134 [details] Patch to version 0.05 - Fixed ports issues (i.e. man path) in upstream - Upstream version update w/ bug fixes and additional features - limited architecture to non-i386 Poudriere log file to follow. portlint and portclippy approve.