Summary: | devel/protobuf-java: Update to 3.25.3 | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Collin Funk <collin.funk1> | ||||
Component: | Individual Port(s) | Assignee: | Gleb Popov <arrowd> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | arrowd | ||||
Priority: | --- | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
URL: | https://github.com/protocolbuffers/protobuf/releases/tag/v25.3 | ||||||
Attachments: |
|
Description
Collin Funk
2024-02-19 02:48:55 UTC
databases/mysql-connector-j seems to be the only consumer of this port. Did you check that it works with this new version? (In reply to Gleb Popov from comment #1) Oops, I didn't see that only one project uses it. I would have made sure to test it if I had known. I was updating it because I saw it was out-of-date and without a maintainer. How much testing did you want done? It appears that this package is only used by databases/mysql-connector-j for the X DevAPI according to the GitHub page [1]. I don't manage any databases but I can install it and try to write some basic tests using the documentation found here [2] [3]. [1] https://github.com/mysql/mysql-connector-j [2] https://dev.mysql.com/doc/connector-j/en/preface.html [3] https://dev.mysql.com/doc/x-devapi-userguide/en/preface.html Well, you don't really need to go that far. It is unrealistic to ask a contributor to go over all the dependencies and do such an extensive testing. I only wanted to know a degree of confidence that this update won't break anything. Do you maybe know if protobuf major releases break API (or ABI, is there a such thing in Java?) If you have Java knowledge, maybe you can figure what protobuf versions does mysql-connector-j expect? If not, let's just push this and see if someone complains. (In reply to Gleb Popov from comment #3) I'm not too experienced with protobuf. I took a quick look at their release page again and they mark breaking changes. 3.22.2 -> 3.25.3 seems to be pretty safe. Unless I missed something, Java doesn't seem to have any breaking changes. If you look at the 3.26 RC's you can see how breaking changes are marked. mysql-connector-j is version 8.1.0 in main right now. From what I could find, version 8.0.32 bumped the dependency to protobuf-java 3.21.9 [1]. mysql-connector-j version 8.3.0 bumped it to protobuf-java 3.25.1 [2]. Whenever the maintainer updates it I assume they will probably run into build problems and have to update this first. Hopefully that helps you know about potential breakage. :) [1] https://github.com/mysql/mysql-connector-j/blob/805f872a57875f311cb82487efcfb070411a3fa0/CHANGES#L108C54-L108C74 [2] https://github.com/mysql/mysql-connector-j/blame/805f872a57875f311cb82487efcfb070411a3fa0/CHANGES#L15 A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=535951677e4aabfe138d41907019f08c2fdc9a2f commit 535951677e4aabfe138d41907019f08c2fdc9a2f Author: Collin Funk <collin.funk1@gmail.com> AuthorDate: 2024-02-22 05:43:01 +0000 Commit: Gleb Popov <arrowd@FreeBSD.org> CommitDate: 2024-02-22 05:50:10 +0000 devel/protobuf-java: Update to 3.25.3 PR: 277153 devel/protobuf-java/Makefile | 2 +- devel/protobuf-java/distinfo | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) Thank you for your analysis. I've gone ahead and pushed the update. |