Bug 277212

Summary: net-mgmt/icingaweb2-module-director-php82: Requires net-mgmt/icingaweb2-module-icubator-php82 version >= 0.21.0 but port tree provides only version 0.20.0
Product: Ports & Packages Reporter: O. Hartmann <ohartmann>
Component: Individual Port(s)Assignee: Jochen Neumeister <joneum>
Status: Closed FIXED    
Severity: Affects Many People CC: flo, gettoknowmi, joneum
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://icinga.com/blog/2024/02/08/security-updates-for-icinga-director/
Attachments:
Description Flags
update icingaweb2-module-incubator to 0.22.0 none

Description O. Hartmann 2024-02-21 18:07:54 UTC
Recent update of git ports tree:

From https://git.freebsd.org/ports
   ddcefa1b7576..aa74318603cb  main       -> origin/main
   fb4eb1df56aa..9eeb031e81c7  2024Q1     -> origin/2024Q1
Updating ddcefa1b7576..aa74318603cb

Port net-mgmt/icingaweb2-module-director-php82 requires  runtime net-mgmt/icingaweb2-module-icubator-php82 version >= 0.21.0,  but ports tree provides only version 0.20.0 of the port. So net-mgmt/icingaweb2-module-director-php82 is broken on recent builds.

This discrepancy in port's requirement and provision renders a recent repository (poudriere built ...) unusable when it comes to icinga2/icingaweb2-module-director-php82. Running such ports in a working system signals disabled director module!
Comment 1 Florian Smeets freebsd_committer freebsd_triage 2024-02-21 22:43:58 UTC
Created attachment 248668 [details]
update icingaweb2-module-incubator to 0.22.0

Fixes my icinga2 after the recent updates
Comment 2 Florian Smeets freebsd_committer freebsd_triage 2024-02-21 22:45:30 UTC
(In reply to O. Hartmann from comment #0)

After applying the attached patch you also need to restore this line in pkg-plist for the director daemon to work again

-@dir(%%DIRECTOR_USER%%,DIRECTOR_GROUP%%,0775) /var/run/icinga-director
Comment 3 Jochen Neumeister freebsd_committer freebsd_triage 2024-02-27 14:59:39 UTC
(In reply to Florian Smeets from comment #1)

Hi,

for incubator,i am the wrong person: https://www.freshports.org/net-mgmt/icingaweb2-module-incubator

Maintainer: gettoknowmi@yahoo.com
Comment 4 Florian Smeets freebsd_committer freebsd_triage 2024-02-27 16:14:30 UTC
(In reply to Jochen Neumeister from comment #3)

Jochen, can you please take 10 seconds to actually read the PR?

1. Look at the link in the URL field.

   "01. Upgrade icinga-php-incubator to version 0.22.0"

icinga-php-incubator 0.22.0 is a requirement for the update to icingaweb2-module-director you committed. This is the first way your recent update broke Icinga director.

2. Look at comment two in this PR https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277212#c2 or look at the email I sent about this. https://lists.freebsd.org/archives/dev-commits-ports-main/2024-February/094366.html

You also lost important pkg-plist information, that cause the icinga-director daemon to break / not start.

You broke it, so it's your obligation to fix it, even if it requires updating a module maintained by someone else. You should have made sure that the dependencies are up to date before committing the director update.

I hope this clarifies why you are in the assignee field.

Florian
Comment 5 Jochen Neumeister freebsd_committer freebsd_triage 2024-02-27 16:24:06 UTC
(In reply to Florian Smeets from comment #4)

Could it be that you have a private problem with me, the way you constantly address me in public?
Comment 6 Florian Smeets freebsd_committer freebsd_triage 2024-02-27 16:56:51 UTC
(In reply to Jochen Neumeister from comment #5)

I'm a bit at a loss why you would think so. We are an open source project. We communicate in PRs (that are public) and mailing lists that are public.

I've been running current for more than twenty years, I cannot count how often I reported breakage in current to the mailing list, nobody ever accused me of having any personal issues with them.

Replying to all on commits saves other people that might have the same issue time. They will see that someone else has the issue, and in case of my last email also see what the fix is. My mail was 6 days ago, so in the meantime people would have had everything they needed to fix the port themselves.

Am I frustrated with stuff that looks untested breaking my production? Very.

Florian
Comment 7 Jochen Neumeister freebsd_committer freebsd_triage 2024-02-27 17:02:38 UTC
So you think it's okay to address someone here who has pointed out to you that he is not the maintainer of the patch? You think it's ok how you constantly address me in other PRs or go to portmgr to complain? If someone doesn't respond quickly enough, make them aware of it with a private email.
It's frustrating the way you act towards me.
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-02-28 20:48:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f50d7d57415540722c87b8164e5b0b20b0fab1c0

commit f50d7d57415540722c87b8164e5b0b20b0fab1c0
Author:     Florian Smeets <flo@FreeBSD.org>
AuthorDate: 2024-02-28 20:39:34 +0000
Commit:     Florian Smeets <flo@FreeBSD.org>
CommitDate: 2024-02-28 20:46:44 +0000

    net-mgmt/icingaweb2-module-director: Fix icinga-director daemon

    The last update lost important information from the pkg-plist. Restore
    it to make it possible to start icinga-daemon again. Without this
    change the daemon could not start because of wrong permissions in
    /var/run.

    Starting icinga_director.
    daemon: ppidfile ``/var/run/icinga-director/icinga_director.pid'': Permission denied
    /usr/local/etc/rc.d/icinga-director: WARNING: failed to start icinga_director

    PR:             277212
    Approved by:    portmgr (blanket, just fix it)
    Fixes:          02bf6f32a982

 net-mgmt/icingaweb2-module-director/Makefile  | 1 +
 net-mgmt/icingaweb2-module-director/pkg-plist | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-02-28 20:48:22 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a330edefd10f71539bacb96dfd9fe09f2b8c9943

commit a330edefd10f71539bacb96dfd9fe09f2b8c9943
Author:     Florian Smeets <flo@FreeBSD.org>
AuthorDate: 2024-02-28 20:32:12 +0000
Commit:     Florian Smeets <flo@FreeBSD.org>
CommitDate: 2024-02-28 20:46:44 +0000

    net-mgmt/icingaweb2-module-incubator: Update to 0.22.0

    In 02bf6f32a982 icingaweb2-module-director was updated to 1.11.1.
    Version 1.11.1 requires the incubator module to be at version 0.22.0
    to work correctly.

    PR:             277212
    Approved by:    portmgr (blanket, just fix it)
    Fixes:  02bf6f32a982

 net-mgmt/icingaweb2-module-incubator/Makefile | 2 +-
 net-mgmt/icingaweb2-module-incubator/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 10 Florian Smeets freebsd_committer freebsd_triage 2024-02-28 20:48:59 UTC
Fixed.