Bug 277295

Summary: multimedia/mplayer: fix icon install
Product: Ports & Packages Reporter: Martin Neubauer <m.ne>
Component: Individual Port(s)Assignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Many People CC: danfe, zarychtam
Priority: --- Flags: riggs: maintainer-feedback+
riggs: merge-quarterly+
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277301
Attachments:
Description Flags
patch fixing icon installation
none
patch without spurious command line flag m.ne: maintainer-approval?

Description Martin Neubauer 2024-02-25 11:30:57 UTC
Created attachment 248728 [details]
patch fixing icon installation

A recent build (on 14-STABLE) of mplayer bailed during staging:

cp -f -f /wrkdirs/usr/ports/multimedia/mplayer/work/mplayer-export-2024-01-06/etc/mplayer256x256.png /wrkdirs/usr/ports/multimedia/mplayer/work/stage/usr/local/share/pixmaps/mplayer.png
cp: /wrkdirs/usr/ports/multimedia/mplayer/work/stage/usr/local/share/pixmaps/mplayer.png: No such file or directory
*** Error code 1

The proposed patch leads to a successful build.
Comment 1 Marek Zarychta 2024-02-25 11:40:33 UTC
I also fell into this and used the same workaround. 100% tested and working solution. Please ship it. It's a side effect of the transition to /usr/local/share.
Comment 2 Martin Neubauer 2024-02-25 13:42:42 UTC
Created attachment 248734 [details]
patch without spurious command line flag
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-02-25 20:27:34 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2e499eeab4df13d21e960beb701af1bb81bac148

commit 2e499eeab4df13d21e960beb701af1bb81bac148
Author:     Thomas Zander <riggs@FreeBSD.org>
AuthorDate: 2024-02-25 20:23:13 +0000
Commit:     Thomas Zander <riggs@FreeBSD.org>
CommitDate: 2024-02-25 20:26:37 +0000

    multimedia/mplayer: Fix icon install with GUI build

    While on it: Remove additional "-f" passing to ${CP}.

    PR:             277295
    Reported by:    m.ne@gmx.net
    MFH:            2024Q1

 multimedia/mplayer/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-02-25 21:38:45 UTC
A commit in branch 2024Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fa7bc9ba3e7aad5bc25cb2038b79956a2292d2fb

commit fa7bc9ba3e7aad5bc25cb2038b79956a2292d2fb
Author:     Thomas Zander <riggs@FreeBSD.org>
AuthorDate: 2024-02-25 20:23:13 +0000
Commit:     Thomas Zander <riggs@FreeBSD.org>
CommitDate: 2024-02-25 20:39:40 +0000

    multimedia/mplayer: Fix icon install with GUI build

    While on it: Remove additional "-f" passing to ${CP}.

    PR:             277295
    Reported by:    m.ne@gmx.net
    MFH:            2024Q1

    (cherry picked from commit 2e499eeab4df13d21e960beb701af1bb81bac148)

 multimedia/mplayer/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 5 Alexey Dokuchaev freebsd_committer freebsd_triage 2024-02-26 09:48:04 UTC
(In reply to Marek Zarychta from comment #1)
> It's a side effect of the transition to /usr/local/share.
How do you mean?  Looks more like a short-living bug fixed in 5cd70cb3b790.