Summary: | graphics/f3d: patch needed to support opencascade-7.8.0 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Thierry Thomas <thierry> | ||||||
Component: | Individual Port(s) | Assignee: | Thierry Thomas <thierry> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | CC: | vvd | ||||||
Priority: | --- | Flags: | yuri:
maintainer-feedback+
|
||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
URL: | https://github.com/f3d-app/f3d/releases/tag/v2.3.0 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 277294 | ||||||||
Attachments: |
|
Description
Thierry Thomas
2024-02-25 17:19:34 UTC
Approved. Please commit it. Upstream released a new version v. 2.3.0. Could you please check if it is compatible with OCCT 7.8.0? See <https://github.com/f3d-app/f3d/releases/tag/v2.3.0>. Created attachment 249034 [details] Upgrade to 2.3.0, but no fix for OCCT 7.8.0 I tried the latest release, v.2.3.0: see the attached patch. You may commit it if you want. But unfortunately it does not include anything to support OpenCascade 7.8.0! I opened an issue to report the problem: <https://github.com/f3d-app/f3d/issues/1304>. Created attachment 249057 [details] Upgrade to 2.3.0, with a fix for OCCT 7.8.0 This second patch upgrades f3d to 2.3.0, and it also fix the problem with OpenCascade 7.8.0. A PR has been submitted upstream: see <https://github.com/f3d-app/f3d/pull/1306>. Note: this patch allows to build with the previous releases of OpenCascade, and it can be committed right now. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=fea222604fc0b3ed6bcdd48324d1a7a462128dd7 commit fea222604fc0b3ed6bcdd48324d1a7a462128dd7 Author: Thierry Thomas <thierry@FreeBSD.org> AuthorDate: 2024-03-08 10:07:26 +0000 Commit: Thierry Thomas <thierry@FreeBSD.org> CommitDate: 2024-03-21 18:01:17 +0000 graphics/f3d: upgrade to 2.3.0 Release notes at <https://github.com/f3d-app/f3d/releases/tag/v2.3.0>. Also fix with OpenCascade 7.8.0: See <https://github.com/f3d-app/f3d/issues/1304>. PR: 277308 Approved by: yuri (maintainer) graphics/f3d/Makefile | 11 +- graphics/f3d/distinfo | 6 +- .../files/patch-plugins_occt_CMakeLists.txt (new) | 35 ++ ...-plugins_occt_module_vtkF3DOCCTReader.cxx (new) | 381 +++++++++++++++++++++ graphics/f3d/pkg-plist | 5 +- 5 files changed, 432 insertions(+), 6 deletions(-) Committed, thanks! Maybe make mpi optional dependency, but default? f3d doesn't link with libmpich and with several other libraries: ====> Running Q/A tests (stage-qa) Warning: you might not need LIB_DEPENDS on libexpat.so Warning: you might not need LIB_DEPENDS on libjpeg.so Warning: you might not need LIB_DEPENDS on libpng.so Warning: you might not need LIB_DEPENDS on libtiff.so Warning: you might not need LIB_DEPENDS on libGLU.so Warning: you might not need LIB_DEPENDS on libmpich.so ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for items in pkg-plist which are not in STAGEDIR ===> No pkg-plist issues found (check-plist) =>> Checking for staging violations... done I've just uploaded my build log at <https://people.freebsd.org/~thierry/f3d-2.3.0.log>. If you look the configure step, you can read: -- Found OpenGL: /usr/local/lib/libOpenGL.so found components: OpenGL GLX -- Found HDF5: hdf5-shared (found version "1.12.2") found components: C HL -- Found NetCDF: netcdf (found version "4.9.2") -- Found ZLIB: /usr/lib/libz.so (found version "1.3.1") -- Found PNG: /usr/local/lib/libpng.so (found version "1.6.42") -- Found MPI_C: /usr/local/lib/libmpi.so (found version "4.0") -- Found MPI: TRUE (found version "4.0") found components: C -- Found X11: /usr/local/include Actually, you are right, MPICH is not inherited from VTK but from OpenCascade. The messages "Warning: you might not need LIB_DEPENDS on xxx" are just warnings, and may be false: some libraries are checked during configure and just used through ld_open, and the resulting built may vary if they are not found. In this case, I don't know f3d, and I'll let Yuri decide. (In reply to Thierry Thomas from comment #9) > MPICH is not inherited from VTK but from OpenCascade. openmpi installed by VTK. OpenCascade does not depend on openmpi. If replace USES=mpi with USES=mpi:openmpi: -- Found MPI_C: /usr/local/mpi/openmpi/lib/libmpi.so (found version "3.1") -- Found MPI: TRUE (found version "3.1") found components: C USES=mpi pulls huge tree of deps - maybe create option OPENMPI: OPENMPI_USES=mpi:openmpi And add: OCCT_IMPLIES=OPENMPI So we prevent silently grab any mpi if OCCT is on. If you want I can create patch. (In reply to Vladimir Druzenko from comment #10) Yes please, do! And it is always better to avoid a mix of OpenMPI and MPICH. |