Bug 277311

Summary: cad/kicad-devel: patch needed to support opencascade-7.8.0
Product: Ports & Packages Reporter: Thierry Thomas <thierry>
Component: Individual Port(s)Assignee: Thierry Thomas <thierry>
Status: Closed FIXED    
Severity: Affects Some People CC: mr
Priority: --- Flags: bugzilla: maintainer-feedback? (mr)
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277406
Bug Depends on:    
Bug Blocks: 277294    
Attachments:
Description Flags
Patch from Johannes Thyssen Tishman thierry: maintainer-approval? (mr)

Description Thierry Thomas freebsd_committer freebsd_triage 2024-02-25 17:19:47 UTC 
If built against opencascade-7.8.0, kicad-devel-r20230622153548_7 fails with the following error:

-- Found OCC: /usr/local/include/OpenCASCADE (found version "7.8.0") 

*** OpenCascade library missing ***
Could not find a library for TKIGES at /usr/local/lib
Verify your OpenCascade installation or pass CMake
  the library directory as '-DOCC_LIBRARY_DIR=<path>'

CMake Error at cmake/FindOCC.cmake:192 (message):
Call Stack (most recent call first):
  CMakeLists.txt:784 (find_package)


-- Configuring incomplete, errors occurred!
*** Error code 1

Remark: same error in cad/kicad.
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2024-02-26 17:56:21 UTC 
Created attachment 248764 [details]
Patch from Johannes Thyssen Tishman

Johannes Thyssen Tishman proposed a patch for the OpenBSD port, available at <https://www.mail-archive.com/ports@openbsd.org/msg123137.html>.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-03-21 18:03:02 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7632031eb3a9c542cdab66527b459790004cdf91

commit 7632031eb3a9c542cdab66527b459790004cdf91
Author:     Thierry Thomas <thierry@FreeBSD.org>
AuthorDate: 2024-03-17 14:39:52 +0000
Commit:     Thierry Thomas <thierry@FreeBSD.org>
CommitDate: 2024-03-21 18:01:18 +0000

    cad/kicad-devel: support of OpenCascade 7.8.0

    Patch from OpenBSD by Johannes Thyssen Tishman.

    PR:             277311
    Approved by:    maintainer’s time-out

 cad/kicad-devel/Makefile                           |  2 +-
 .../files/patch-cmake_FindOCC.cmake (new)          | 35 ++++++++++++++++++++++
 cad/kicad-devel/files/patch-include-kiway.h        |  4 +--
 ...tch-pcbnew_import__gfx_dxf__import__plugin.cpp} | 20 +++++++++----
 .../files/patch-thirdparty_glew_CMakeLists.txt     |  6 ++--
 .../files/patch-thirdparty_nanodbc_CMakeLists.txt  | 11 ++-----
 6 files changed, 57 insertions(+), 21 deletions(-)
Comment 3 Thierry Thomas freebsd_committer freebsd_triage 2024-03-21 18:08:49 UTC 
Just committed!