Bug 277342

Summary: audio/ardour: Update to 8.4.0 release.
Product: Ports & Packages Reporter: Florian Walpen <dev>
Component: Individual Port(s)Assignee: Muhammad Moinur Rahman <bofh>
Status: Closed FIXED    
Severity: Affects Only Me CC: agh, bofh
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://ardour.org/whatsnew.html
Attachments:
Description Flags
Update Ardour to 8.4.0 release. dev: maintainer-approval+

Description Florian Walpen 2024-02-27 01:47:47 UTC 
Created attachment 248772 [details]
Update Ardour to 8.4.0 release.

Update Ardour to 8.4.0 release. This patch goes from 8.1.0 directly to 8.4.0, update to 8.2.0 didn't get any further attention by committers (bug #275875), and 8.3.0 was skipped by the Ardour developers.

Briefly tested on 14.0-RELEASE amd64.
Comment 1 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2024-03-02 11:36:44 UTC 
When providing git formatted patch do not create the patch first. Create the PR with the synopsis.

Add the following in the commit message:
PR: <THE PR NUMBER>
Approved By: Submitter is maintainer

Then attach the patch. A common misconception is you have to attach a patch while creating the PR which is not true at all. Not required for this one.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-03-02 13:54:49 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=be5cb37f21e9d9bbee75411e8e773d8724f2bb18

commit be5cb37f21e9d9bbee75411e8e773d8724f2bb18
Author:     Florian Walpen <dev@submerge.ch>
AuthorDate: 2023-12-14 16:37:07 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2024-03-02 13:53:14 +0000

    audio/ardour: Update version 8.1.0=>8.4.0

    Changelog: https://ardour.org/whatsnew.html

    PR:             277342
    Approved by:    submitter is maintainer

 audio/ardour/Makefile                                    | 12 +++++++-----
 audio/ardour/distinfo                                    |  6 +++---
 audio/ardour/files/patch-libs_aaf_AAFIAudioFiles.c (new) | 12 ++++++++++++
 audio/ardour/files/patch-libs_aaf_aaf_LibCFB.h (new)     | 11 +++++++++++
 audio/ardour/pkg-plist                                   | 15 +++++++++++++++
 5 files changed, 48 insertions(+), 8 deletions(-)
Comment 3 Florian Walpen 2024-03-02 14:11:28 UTC 
(In reply to Muhammad Moinur Rahman from comment #1)

> When providing git formatted patch do not create the patch first.
> Create the PR with the synopsis.
> 
> Add the following in the commit message:
> PR: <THE PR NUMBER>
> Approved By: Submitter is maintainer

Good point. Thanks for the commit!