Bug 277618

Summary: Fit values of RTAX_CC_ALGO and RTAX_FASTOPEN_NO_COOKIE in netlink headers
Product: Base System Reporter: Marek Zarychta <zarychtam>
Component: standardsAssignee: freebsd-standards (Nobody) <standards>
Status: Closed FIXED    
Severity: Affects Many People CC: emaste, glebius, melifaro
Priority: ---    
Version: CURRENT   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 277619    
Attachments:
Description Flags
patch with fix none

Description Marek Zarychta 2024-03-10 23:53:27 UTC 
Created attachment 249080 [details]
patch with fix

Trying to upgrade our net/bird2 port to BIRD 2.15 version which was released yesterday I experienced a bummer. After an email exchange with Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) he suggested that FreeBSD code has wrongly enumerated route attributes in Netlink headers and indeed it was the culprit.
Please fix it to make it consistent with the Linux version[1].

Reported by: Ondrej 'Santiago' Zajicek <santiago@crfreenet.org>

1. https://github.com/torvalds/linux/blame/master/include/uapi/linux/rtnetlink.h#L461
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-03-11 15:53:53 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=16f8d8829472dfdf6b3b2bb21d652f0bafefccbc

commit 16f8d8829472dfdf6b3b2bb21d652f0bafefccbc
Author:     Marek Zarychta <zarychtam@plan-b.pwste.edu.pl>
AuthorDate: 2024-03-11 15:50:46 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2024-03-11 15:50:46 +0000

    netlink: fix route protocol constant values to match Linux

    Although these particular constants aren't supported, the incorrect
    values break bird 2.15 operation.

    PR:             277618
    Reported by:    Ondrej Zajicek <santiago@crfreenet.org>

 sys/netlink/route/route.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-03-18 16:15:08 UTC 
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=d45714ade3de0db24cb313c84674c2a8573f4690

commit d45714ade3de0db24cb313c84674c2a8573f4690
Author:     Marek Zarychta <zarychtam@plan-b.pwste.edu.pl>
AuthorDate: 2024-03-11 15:50:46 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2024-03-18 16:14:45 +0000

    netlink: fix route protocol constant values to match Linux

    Although these particular constants aren't supported, the incorrect
    values break bird 2.15 operation.

    PR:             277618
    Reported by:    Ondrej Zajicek <santiago@crfreenet.org>

    (cherry picked from commit 16f8d8829472dfdf6b3b2bb21d652f0bafefccbc)

 sys/netlink/route/route.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-03-18 16:16:09 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=e5c1ba936955d6f74de988db38d6f215e26492cf

commit e5c1ba936955d6f74de988db38d6f215e26492cf
Author:     Marek Zarychta <zarychtam@plan-b.pwste.edu.pl>
AuthorDate: 2024-03-11 15:50:46 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2024-03-18 16:15:28 +0000

    netlink: fix route protocol constant values to match Linux

    Although these particular constants aren't supported, the incorrect
    values break bird 2.15 operation.

    PR:             277618
    Reported by:    Ondrej Zajicek <santiago@crfreenet.org>

    (cherry picked from commit 16f8d8829472dfdf6b3b2bb21d652f0bafefccbc)

 sys/netlink/route/route.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)