Bug 277661
| Summary: | www/redmine51: Add new port | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Xin LI <delphij> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Xin LI <delphij> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | mikael, ohaucke, olevole | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Comment on attachment 249127 [details]
Proposed patch
Requesting for feedback.
You can remove CONFLICTS_INSTALL, pkg handles the conflict just fine rubygem-listen and yard: are only used in the group "development", not sure we want the dep It gets removed in patch-Gemfile anyway rubygem-mocha, rubygem-rubocop* and simplecov are in the group "test" and are removed in patch-Gemfile You can turn them into an OPTION (TEST and DEV) if you find them usefull rubygem-psych: I can't find this gem in Gemfile, is it usefull? I have a local port for redmine51 where I've updated the rubygem version (couldn't commit it yet due to lack of testing): rubygem-csv>= 3.2.6 rubygem-i18n>=1.14.1 rubygem-mail>=2.8.1 rubygem-mini_mime>=1.1.0 rubygem-mini_portile2>=2.8.2 rubygem-net-imap>=0.3.4 rubygem-net-pop>=0.1.2 rubygem-net-smtp>=0.3.3 rubygem-nokogiri>=1.15.2 rubygem-rbpdf>=1.21.3 rubygem-request_store15>=1.5.0 rubygem-rubyzip>=2.3.0 rubygem-commonmarker>=0.23.8 rubygem-deckar01-task_list>=2.3.2 You'll also need a new gem if MYSQL option is used: with_advisory_lock https://www.redmine.org/issues/39437 https://www.redmine.org/projects/redmine/repository/svn/revisions/22458 Created attachment 249146 [details]
Revised patch
Incorporated feedbacks from mikael@
Created attachment 249147 [details]
Revised patch #2
Also removed psych dependency
(In reply to Mikael Urankar from comment #2) Hi, thanks a lot for your feedback! I've revised the patch and added a new port for with_advisory_lock. I'm not sure why it didn't broke on my own setup (nice catch!) so my test coverage is probably not sufficient. I'll continue to do additional testing on the port; in the meantime, if you have your version ready please feel free to commit your version if your version was better. (In reply to Xin LI from comment #5) It's only a runtime problem. I've read the Gemfile and noticed the new dep, nothing more. My version is almost the same as yours, you reorder the BUILD_DEPENDS and I did not. You can drop CONFLICTS_INSTALL in redmine50 It seems bsd.redmine.mk is missing in redmine51, it's used for redmine plugins. Created attachment 249294 [details]
Revised patch #3
(Removed CONFLICTS change in www/redmine50 and changed with_advisory_lock dependency to include activerecord version).
The bsd.redmine.mk was removed because there is no in-tree usage of it; I don't really have strong opinion regarding it, but it was weird to add a file that is not being used by any other ports (even though the only needed change would be to s/50/51/g).
(In reply to Xin LI from comment #8) I have some out of tree redmine modules, I can live without this file but it'd nice to ship it. Looks good otherwise. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1932cdae48b0471f05354eb7f5159ba704c48c0a commit 1932cdae48b0471f05354eb7f5159ba704c48c0a Author: Xin LI <delphij@FreeBSD.org> AuthorDate: 2024-04-01 05:41:13 +0000 Commit: Xin LI <delphij@FreeBSD.org> CommitDate: 2024-04-01 05:42:08 +0000 www/redmine51: Add new port Redmine is a flexible project management web application written using Ruby on Rails framework, it is cross-platform and cross-database. PR: ports/277661 Reviewed by: mikael www/Makefile | 1 + www/redmine51/Makefile (new) | 124 ++ www/redmine51/bsd.redmine.mk (new) | 78 + www/redmine51/distinfo (new) | 3 + www/redmine51/files/commonmark.rb (new) | 2 + www/redmine51/files/markdown.rb (new) | 1 + www/redmine51/files/mini_magick.rb (new) | 1 + www/redmine51/files/mysql.rb (new) | 2 + www/redmine51/files/patch-Gemfile (new) | 124 ++ www/redmine51/files/pg.rb (new) | 1 + www/redmine51/files/redmine.in (new) | 39 + www/redmine51/files/thin.rb (new) | 1 + www/redmine51/pkg-descr (new) | 21 + www/redmine51/pkg-message (new) | 18 + www/redmine51/pkg-plist (new) | 2275 ++++++++++++++++++++++++++++++ 15 files changed, 2691 insertions(+) |
Created attachment 249127 [details] Proposed patch I would like to be maintainer of new port as I actively uses it.