Bug 277743
| Summary: | devel/jetbrains-pty4j: Added aarch64 compatibility | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dmitry Wagin <dmitry.wagin> | ||||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||||
| Status: | Closed Works As Intended | ||||||||||||
| Severity: | Affects Only Me | CC: | freebsd-2024, lwhsu, mi | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 249711 [details]
Use bsd.lib.mk
Instead of trying to use the upstream's makefiles, why not simply compile the little shared library using the standard bsd.lib.mk? That will make the port build for all architectures too...
The proposed patch does that while also providing these other minor improvements:
- upgrade the port to upstream's 0.12.26
- stop extracting the upstream's pre-built binaries (which they never should've
added to their git repo in the first place).
Created attachment 249712 [details] files/BSDmakefile > The proposed patch does that Argh, the `git diff` didn't include my newly-added files/BSDmakefile with the patch, so here it is by itself. Sorry for the additional noise. Created attachment 249729 [details]
jetbrains-pty4j.diff
- upgrade the port to upstream's 0.12.26
- stop extracting the upstream's pre-built binaries.
(In reply to Mikhail Teterin from comment #1) I don't see the point in maintaining an additional Makefile. All architectures are not needed, only specific ones. (In reply to Dmitry Wagin from comment #4) > I don't see the point in maintaining an additional Makefile Seems like fewer lines of code, than you have now. And no need for gmake any more... > All architectures are not needed, only specific ones. I don't understand this statement... Why shouldn't the port (try to) cover all of FreeBSD's architectures? (In reply to Mikhail Teterin from comment #5) >> All architectures are not needed, only specific ones. > I don't understand this statement... Why shouldn't the port (try to) cover all of FreeBSD's architectures? Other ports that use this port are limited by these architectures, there is no point in building (just a waste of resources). (In reply to Dmitry Wagin from comment #6) > Other ports that use this port are limited by these architectures, > there is no point in building (just a waste of resources). For one, there may be other uses of this port. Secondly, those existing depending ports may have their limitations removed too some day. (In reply to Mikhail T. from comment #8) When any of this happens, we will take action. We will not waste resources now. |
Created attachment 249223 [details] jetbrains-pty4j.diff Added aarch64 compatibility and cleanup port