Bug 277892
| Summary: | net/libiscsi: update to 1.20.0 (plus a little further) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Martin Birgmeier <d8zNeCFG> | ||||||
| Component: | Individual Port(s) | Assignee: | Zsolt Udvari <uzsolt> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | diizzy, uzsolt | ||||||
| Priority: | --- | Flags: | d8zNeCFG:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Forgot to add the emulators/qemu should be bumped because of a shlib change. Created attachment 249410 [details]
git format-patch
(In reply to Martin Birgmeier from comment #1) You can "obsolote" earlier patches. Next time please care set "maintainer-feedback" (as I see you're the maintainer). Thanks! o.k. learned something, did it. -- Martin Please use the "proper" length for short tags in GH_TAGNAME https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github (see examples below) Drop GNU_CONFIGURE_MANPREFIX=${PREFIX}/share Are patches upstreamed (if possible)? The referenced document does not seem to contain a definition of the "proper" length for GH_TAGNAME; the examples variably use 7 or 8 characters. The port uses 12 to be consistent with current FreeBSD src conventions.
Drop GNU_CONFIGURE_MANPREFIX=${PREFIX}/share: O.k., but how to achieve its effect otherwise? - Shouldn't all ports put manpages in /usr/local/share/man instead of /usr/local/man nowadays?
There are no patches to the port's sources, so nothing needs to be upstreamed.
-- Martin
GNU_CONFIGURE_MANPREFIX is set by the framework, https://cgit.freebsd.org/ports/tree/Mk/bsd.port.mk#n2716 Current version have patches? https://cgit.freebsd.org/ports/tree/net/libiscsi/files I'll submit patches to Porters Handbook to fix this inconsistency Best regards, Daniel A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=19065142725329713ffda2b83a35e9deb55dbcc4 commit 19065142725329713ffda2b83a35e9deb55dbcc4 Author: Martin Birgmeier <d8zNeCFG@aon.at> AuthorDate: 2024-08-11 13:04:46 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2024-08-11 13:09:21 +0000 net/libiscsi: update to 1.20.0 Strip library. Pet portfmt. PR: 277892 Approved by: submitter is maintainer net/libiscsi/Makefile | 21 +++++++++++---------- net/libiscsi/distinfo | 6 +++--- net/libiscsi/pkg-plist | 7 +++++-- 3 files changed, 19 insertions(+), 15 deletions(-) Committed, thanks! Thank you for the cleanup & commit! Don't forget to bump qgis... -- Martin ... I mean qemu A commit in branch 2024Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c938f25d994b474f2e0dc3950cf3f9d86f844288 commit c938f25d994b474f2e0dc3950cf3f9d86f844288 Author: Martin Birgmeier <d8zNeCFG@aon.at> AuthorDate: 2024-08-11 13:04:46 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-08-13 18:38:50 +0000 net/libiscsi: update to 1.20.0 Strip library. Pet portfmt. PR: 277892 Approved by: submitter is maintainer (cherry picked from commit 19065142725329713ffda2b83a35e9deb55dbcc4) net/libiscsi/Makefile | 21 +++++++++++---------- net/libiscsi/distinfo | 6 +++--- net/libiscsi/pkg-plist | 7 +++++-- 3 files changed, 19 insertions(+), 15 deletions(-) |
Created attachment 249409 [details] patch to upgrade libiscsi to 1.20.0.240205 Please find attached a patch which upgrades net/libiscsi to fef688aa9980, slightly after 1.20.0 -- Martin