Bug 277926

Summary: www/py-django-bootstrap-pagination: Deprecate/Set to expire
Product: Ports & Packages Reporter: Kai Knoblich <kai>
Component: Individual Port(s)Assignee: Kai Knoblich <kai>
Status: Closed FIXED    
Severity: Affects Only Me CC: dbaio
Priority: --- Flags: dbaio: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/jmcclell/django-bootstrap-pagination
Bug Depends on:    
Bug Blocks: 276319    
Attachments:
Description Flags
deprecate-py-django-bootstrap-pagination.patch dbaio: maintainer-approval+

Description Kai Knoblich freebsd_committer freebsd_triage 2024-03-24 17:10:08 UTC 
Created attachment 249451 [details]
deprecate-py-django-bootstrap-pagination.patch

Hi Danilo,

when checking the compatibility for Django 4.2, because Django 3.2 will reach its EoL in April, I noticed that the www/py-django-bootstrap-pagination port isn't compatible with Django 4.2:

> [...]
>  File "/usr/local/lib/python3.9/site-packages/django/core/checks/registry.py", line 88, in run_checks
>    new_errors = check(app_configs=app_configs, databases=databases)
>  File "/usr/local/lib/python3.9/site-packages/django/core/checks/templates.py", line 60, in check_for_template_tags_with_the_same_name
>    for module_name, module_path in get_template_tag_modules():
>  File "/usr/local/lib/python3.9/site-packages/django/template/backends/django.py", line 105, in get_template_tag_modules
>    for name in get_package_libraries(pkg):
>  File "/usr/local/lib/python3.9/site-packages/django/template/backends/django.py", line 130, in get_package_libraries
>    raise InvalidTemplateLibrary(
> django.template.library.InvalidTemplateLibrary: Invalid template library specified. ImportError raised when trying to load 'bootstrap_pagination.templatetags.bootstrap_pagination': cannot import name 'ugettext_lazy' from 'django.utils.translation' (/usr/local/lib/python3.9/site-packages/django/utils/translation/__init__.py)

The upstream repository has been archived in 2021 so it's unlikely to get a working fix from there.

Thus would it be OK for you to deprecate the port and set an expiration date for it?
Comment 1 Danilo G. Baio freebsd_committer freebsd_triage 2024-03-24 22:22:46 UTC 
Yes sure, please, go ahead.
Thank you.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-03-27 05:40:28 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b27675f9fb5a7d27cceeb9249673595ac3a6ae48

commit b27675f9fb5a7d27cceeb9249673595ac3a6ae48
Author:     Kai Knoblich <kai@FreeBSD.org>
AuthorDate: 2024-03-27 05:35:54 +0000
Commit:     Kai Knoblich <kai@FreeBSD.org>
CommitDate: 2024-03-27 05:35:54 +0000

    www/py-django-bootstrap-pagination: Deprecate/Set to expire

    * The code is not compatible with Django 4.2 or newer and upstream
      stopped working on the project in 2021 and archived the repository.

    PR:             277926
    Approved by:    dbaio (maintainer)

 www/py-django-bootstrap-pagination/Makefile | 3 +++
 1 file changed, 3 insertions(+)
Comment 3 Kai Knoblich freebsd_committer freebsd_triage 2024-03-27 05:48:13 UTC 
(In reply to Danilo G. Baio from comment #1)

Committed, thank you for your swift review and feedback!