Bug 277945

Summary: devel/gettext-runtime: fails build WITH_LTO=yes
Product: Ports & Packages Reporter: Benjamin Takacs <nimaje+fbz>
Component: Individual Port(s)Assignee: Tijl Coosemans <tijl>
Status: Closed FIXED    
Severity: Affects Only Me CC: tatsuki_makino, tijl
Priority: --- Flags: tijl: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
devel/gettext-runtime: mark LTO_UNSAFE nimaje+fbz: maintainer-approval? (tijl)

Description Benjamin Takacs 2024-03-25 12:43:24 UTC
Created attachment 249470 [details]
devel/gettext-runtime: mark LTO_UNSAFE

devel/gettext-runtime fails to build if WITH_LTO=yes is set.

relevant part of the log:
--- libintl.la ---
/bin/sh ./libtool  --tag=CC    --mode=link cc -fvisibility=hidden -O2 -pipe  -DLIBICONV_PLUG -flto=thin -fstack-protector-strong -fno-strict-aliasing       -no-undefined  -export-symbols-regex '^([^_]|_[^l]|_l[^i]|_li[^b]|_lib[^i]|_libi[^n]|_libin[^t]|_libint[^l]|_libintl[^_]).*'  -version-info 12:0:4  -rpath /usr/local/lib -flto=thin -fstack-protector-strong -o libintl.la  bindtextdom.lo dcgettext.lo dgettext.lo gettext.lo  finddomain.lo hash-string.lo loadmsgcat.lo localealias.lo  textdomain.lo l10nflist.lo explodename.lo dcigettext.lo  dcngettext.lo dngettext.lo ngettext.lo plural.lo plural-exp.lo  langprefs.lo log.lo printf.lo setlocale.lo version.lo osdep.lo  intl-compat.lo gnulib-lib/libgnu.la  
libtool: link: /usr/bin/nm  .libs/bindtextdom.o .libs/dcgettext.o .libs/dgettext.o .libs/gettext.o .libs/finddomain.o .libs/hash-string.o .libs/loadmsgcat.o .libs/localealias.o .libs/textdomain.o .libs/l10nflist.o .libs/explodename.o .libs/dcigettext.o .libs/dcngettext.o .libs/dngettext.o .libs/ngettext.o .libs/plural.o .libs/plural-exp.o .libs/langprefs.o .libs/log.o .libs/printf.o .libs/setlocale.o .libs/version.o .libs/osdep.o .libs/intl-compat.o   gnulib-lib/.libs/libgnu.a |  | /usr/bin/sed 's/.* //' | sort | uniq > .libs/libintl.exp
eval: 1: Syntax error: "|" unexpected
*** [libintl.la] Error code 2

Until that is fixed it should be marked as LTO_UNSAFE
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-03-25 16:55:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=276c687eb65b6600c836186d7bd6cbc8bf934167

commit 276c687eb65b6600c836186d7bd6cbc8bf934167
Author:     Tijl Coosemans <tijl@FreeBSD.org>
AuthorDate: 2024-03-25 16:11:37 +0000
Commit:     Tijl Coosemans <tijl@FreeBSD.org>
CommitDate: 2024-03-25 16:53:33 +0000

    devel/gettext*: Mark LTO_UNSAFE

    PR:             277945

 devel/gettext/Makefile.common | 1 +
 1 file changed, 1 insertion(+)
Comment 2 Tatsuki Makino 2024-03-27 09:45:08 UTC
This seems to be the same as bug 277946.
So, same as bug 277946 comment #1.