Bug 277948

Summary: devel/gnulib: buildfailure due to environment collision when gmake in use
Product: Ports & Packages Reporter: O. Hartmann <ohartmann>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: New ---    
Severity: Affects Many People CC: arrowd, tatsuki_makino, tijl
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
correct env patch for gmake none

Description O. Hartmann 2024-03-25 13:33:46 UTC
Created attachment 249473 [details]
correct env patch for gmake

Host: recent CURRENT (FreeBSD 15.0-CURRENT #8 main-n268989-caccf6d3c008: Mon Mar 25 07:57:05 CET 2024 amd64), recent ports tree 

From https://git.freebsd.org/ports
   914d2a1589b8..727be8db1efd  main       -> origin/main

as of other ports having trouble of proper environments when gmake is in use,

one has to replace 
 do-build:
-       cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ${MAKE_CMD} -C doc info html
+       cd ${WRKSRC} && ${SETENVI} ${MAKE_ENV} ${MAKE_CMD} -C doc info html

(see patch) as a workaround. Otherwise build will fail.
Comment 1 Gleb Popov freebsd_committer freebsd_triage 2024-03-25 18:25:52 UTC
The port builds fine for me. What error are you getting?
Comment 2 Tatsuki Makino 2024-03-27 10:55:46 UTC
(In reply to Gleb Popov from comment #1)

It probably means that we have to keep up with changes like commit 572f2361692640bc27729191b1267aa3fcc354a7.

Instead of using a do-build target here, the following variables could be substituted.
But I say this without any testing :)

BUILD_WRKSRC= ${WRKSRC}/doc
ALL_TARGET= info html
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-03-28 11:52:50 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8e42e5a3a218aa452695884729dca0dae44a1b6e

commit 8e42e5a3a218aa452695884729dca0dae44a1b6e
Author:     Gleb Popov <arrowd@FreeBSD.org>
AuthorDate: 2024-03-28 11:48:03 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2024-03-28 11:51:07 +0000

    devel/gnulib: Simplify build stage

    PR:             277948
    Suggested by:   Tatsuki Makino <tatsuki_makino@hotmail.com>

 devel/gnulib/Makefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Comment 4 Gleb Popov freebsd_committer freebsd_triage 2024-03-28 11:55:46 UTC
(In reply to Tatsuki Makino from comment #2)
You're absolutely right, Makino-san, I pushed your suggestion.

Olivier, does this fix the problem for you?