Bug 277972

Summary: security/amavisd-new: Uses INSTALL_SCRIPT for installing configuration file
Product: Ports & Packages Reporter: Mikael Urankar <mikael>
Component: Individual Port(s)Assignee: Florian Smeets <flo>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (flo)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   

Description Mikael Urankar freebsd_committer freebsd_triage 2024-03-26 09:15:43 UTC 
Are there any reasons to use INSTALL_SCRIPT for installing configuration file? The config files end up with a 755 perm. INSTALL_DATA is more appropriate.
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-03-26 21:32:44 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e18075d840ebaf663f853515312094f215425f69

commit e18075d840ebaf663f853515312094f215425f69
Author:     Florian Smeets <flo@FreeBSD.org>
AuthorDate: 2024-03-26 21:31:33 +0000
Commit:     Florian Smeets <flo@FreeBSD.org>
CommitDate: 2024-03-26 21:32:23 +0000

    security/amavisd-new: fix config file installation

    Don't use INSTALL_SCRIPT to install config file. Use the more
    appropriate INSTALL_DATA.

    PR:             277972
    Reported by:    mikael

 security/amavisd-new/Makefile | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Comment 2 Florian Smeets freebsd_committer freebsd_triage 2024-03-26 21:41:26 UTC 
According to git blame it has been that way for 20 years. I've been using this port for about that time and never noticed. Thanks for the report. I committed the necessary changes.