Bug 278001

Summary: emulators/mupen64plus-video-glide64mk2: fix build with clang 18
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: Jose Alonso Cardenas Marquez <acm>
Status: Closed FIXED    
Severity: Affects Some People Flags: bugzilla: maintainer-feedback? (acm)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 276104    
Attachments:
Description Flags
emulators/mupen64plus-video-glide64mk2: fix build with clang 18 none

Description Dimitry Andric freebsd_committer freebsd_triage 2024-03-27 20:20:06 UTC 
I am unsure if clang 18 actually has anything to do with it, but
whatever the case, emulators/mupen64plus-video-glide64mk2 does not
build:

    CXX _obj/Glide64/rdp.o
../../src/Glide64/rdp.cpp:1863:11: error: use of undeclared identifier 'bswap32'
 1863 |     *v5 = bswap32(v12);
      |           ^

And a bunch more of these. Fix it by including <sys/endian.h> in the
__FreeBSD__ case in src/Glide64/Util.h.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2024-03-27 20:21:11 UTC 
Created attachment 249525 [details]
emulators/mupen64plus-video-glide64mk2: fix build with clang 18
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-04-20 14:25:14 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=39dd48012d9233d058e7622db3e45d0f2f5e28e3

commit 39dd48012d9233d058e7622db3e45d0f2f5e28e3
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-03-27 20:16:09 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-04-20 14:23:09 +0000

    emulators/mupen64plus-video-glide64mk2: fix build with clang 18

    I am unsure if clang 18 actually has anything to do with it, but
    whatever the case, emulators/mupen64plus-video-glide64mk2 does not
    build:

        CXX _obj/Glide64/rdp.o
    ../../src/Glide64/rdp.cpp:1863:11: error: use of undeclared identifier 'bswap32'
     1863 |     *v5 = bswap32(v12);
          |           ^

    And a bunch more of these. Fix it by including <sys/endian.h> in the
    __FreeBSD__ case in src/Glide64/Util.h.

    PR:             278001
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2024Q2

 .../mupen64plus-video-glide64mk2/files/patch-src_Glide64_Util.h   | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-04-20 14:26:19 UTC 
A commit in branch 2024Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1d30066dccab85388b1f7947b96d5b00951e381a

commit 1d30066dccab85388b1f7947b96d5b00951e381a
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-03-27 20:16:09 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-04-20 14:25:00 +0000

    emulators/mupen64plus-video-glide64mk2: fix build with clang 18

    I am unsure if clang 18 actually has anything to do with it, but
    whatever the case, emulators/mupen64plus-video-glide64mk2 does not
    build:

        CXX _obj/Glide64/rdp.o
    ../../src/Glide64/rdp.cpp:1863:11: error: use of undeclared identifier 'bswap32'
     1863 |     *v5 = bswap32(v12);
          |           ^

    And a bunch more of these. Fix it by including <sys/endian.h> in the
    __FreeBSD__ case in src/Glide64/Util.h.

    PR:             278001
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2024Q2

    (cherry picked from commit 39dd48012d9233d058e7622db3e45d0f2f5e28e3)

 .../mupen64plus-video-glide64mk2/files/patch-src_Glide64_Util.h   | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)