Bug 278098

Summary: [exp-run] remove Tcl/Tk 8.5
Product: Ports & Packages Reporter: Pietro Cerutti <gahr>
Component: Individual Port(s)Assignee: Pietro Cerutti <gahr>
Status: Closed FIXED    
Severity: Affects Only Me Flags: antoine: exp-run+
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
remove tcl/tk 85 from USES
none
remove tcl/tk 85 from USES and fix x11-toolkits/tk85
none
remove tcl/tk 85 from USES, fix x11-toolkits/tk85, remove bogus check on min version none

Description Pietro Cerutti freebsd_committer freebsd_triage 2024-04-01 14:32:47 UTC
Created attachment 249636 [details]
remove tcl/tk 85 from USES

Tcl/Tk 8.5 is EOL. I want to remove the lang/tcl85 and x11-toolkits/tk85 ports, but before doing that I need to remove the possibility to USES=tcl:85 and USES=tk:85.

I think this might require an exp-run.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2024-04-01 23:05:28 UTC
The patch looks wrong,  x11-toolkits/tk85 now depends on lang/tcl86
Comment 2 Pietro Cerutti freebsd_committer freebsd_triage 2024-04-02 06:43:35 UTC
Created attachment 249653 [details]
remove tcl/tk 85 from USES and fix x11-toolkits/tk85
Comment 3 Pietro Cerutti freebsd_committer freebsd_triage 2024-04-02 06:45:14 UTC
Thanks Antoine, I've updated the patch to fix x11-toolkits/tk85 so it doesn't USES=tcl but LIB_DEPENDS on lang/tcl85 explicitely.
Comment 4 Antoine Brodin freebsd_committer freebsd_triage 2024-04-02 08:07:06 UTC
Some ports are ignored with "Minimum tcltk version 86+ is meaningless":

audio/din
databases/tdbc
devel/critcl
net-im/tkabber
www/mod_rivet
Comment 5 Pietro Cerutti freebsd_committer freebsd_triage 2024-04-02 08:17:17 UTC
Right - I guess the "is meaningless" IGNORE is wrong, now that there's both 86 and 87.
Comment 6 Pietro Cerutti freebsd_committer freebsd_triage 2024-04-02 08:20:59 UTC
Created attachment 249656 [details]
remove tcl/tk 85 from USES, fix x11-toolkits/tk85, remove bogus check on min version
Comment 7 Pietro Cerutti freebsd_committer freebsd_triage 2024-04-02 08:21:25 UTC
I've updated the patch
Comment 8 Antoine Brodin freebsd_committer freebsd_triage 2024-04-08 20:03:11 UTC
Exp-run looks fine
Comment 9 Pietro Cerutti freebsd_committer freebsd_triage 2024-04-09 06:09:18 UTC
Thanks very much!
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-04-09 06:37:38 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=754b2ef182b8622b129c78bd86993393f40345a0

commit 754b2ef182b8622b129c78bd86993393f40345a0
Author:     Pietro Cerutti <gahr@FreeBSD.org>
AuthorDate: 2024-04-09 06:26:41 +0000
Commit:     Pietro Cerutti <gahr@FreeBSD.org>
CommitDate: 2024-04-09 06:36:33 +0000

    Mk/Uses/tcl.mk: remove support for Tcl/Tk 8.5

    In preparation for removing the lang/tcl85 and x11-toolkits/tk85 ports.
    The 8.5 series is EOL.

    PR:             278098
    Approved by:    antoine (portmgr, exp-run)

 Mk/Uses/tcl.mk                          |  19 ++---
 lang/tclX/Makefile                      |   5 --
 lang/tclX/files/tcl85-test-patch (gone) | 134 --------------------------------
 x11-toolkits/tk85/Makefile              |  10 ++-
 4 files changed, 13 insertions(+), 155 deletions(-)