Bug 278237

Summary: textproc/opensearch fails to package with PLUGINS=off
Product: Ports & Packages Reporter: Martin Waschbüsch <martin>
Component: Individual Port(s)Assignee: opensearch
Status: Closed FIXED    
Severity: Affects Only Me CC: acm
Priority: --- Flags: bugzilla: maintainer-feedback? (opensearch)
Version: Latest   
Hardware: Any   
OS: Any   

Description Martin Waschbüsch 2024-04-07 18:27:13 UTC
Just like in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269909
opensearch once again fails to build when disabling plugins:

===>   Building opensearch-2.11.1
pkg-static: Unable to access file /wrkdirs/usr/ports/textproc/opensearch/work/stage/usr/local/etc/opensearch/opensearch-notifications-core/:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/textproc/opensearch/work/stage/usr/local/etc/opensearch/opensearch-notifications/:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/textproc/opensearch/work/stage/usr/local/etc/opensearch/opensearch-observability/:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/textproc/opensearch/work/stage/usr/local/etc/opensearch/opensearch-performance-analyzer/:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/textproc/opensearch/work/stage/usr/local/etc/opensearch/opensearch-reports-scheduler/:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/textproc/opensearch/work/stage/usr/local/etc/opensearch/opensearch-security/:No such file or directory
*** Error code 1

Stop.
make: stopped in /usr/ports/textproc/opensearch


At a first glance, in the Makefile

        ${ECHO} "@dir(opensearch,opensearch,0750) ${ETCDIR}/opensearch-notifications-core" >> ${TMPPLIST}
        ${ECHO} "@dir(opensearch,opensearch,0750) ${ETCDIR}/opensearch-notifications" >> ${TMPPLIST}
        ${ECHO} "@dir(opensearch,opensearch,0750) ${ETCDIR}/opensearch-observability" >> ${TMPPLIST}
        ${ECHO} "@dir(opensearch,opensearch,0750) ${ETCDIR}/opensearch-performance-analyzer" >> ${TMPPLIST}
        ${ECHO} "@dir(opensearch,opensearch,0750) ${ETCDIR}/opensearch-reports-scheduler" >> ${TMPPLIST}
        ${ECHO} "@dir(opensearch,opensearch,0750) ${ETCDIR}/opensearch-security" >> ${TMPPLIST}

should all be inside a check for the PLUGINS option

.if ${PORT_OPTIONS:MPLUGINS}
.endif

as these seem to be individual subdirs for the config of the plugins?
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-05-08 20:24:22 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5e57e1f8d68cc6a49bea97f81f8fbdb57121827f

commit 5e57e1f8d68cc6a49bea97f81f8fbdb57121827f
Author:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
AuthorDate: 2024-05-08 20:21:41 +0000
Commit:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
CommitDate: 2024-05-08 20:23:26 +0000

    textproc/opensearch: Fix package issue with PLUGINS=off

    - Bump PORTREVISION

    PR:             278237
    Reported by:    Martin Waschbüsch <martin __at_ waschbuesch.de>

 textproc/opensearch/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Comment 2 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2024-05-08 20:25:02 UTC
Fixed thanks!