Bug 278249

Summary: databases/evolution-data-server: malfunctions when databases/sqlite3 is build with option DQS off
Product: Ports & Packages Reporter: Robert Clausecker <fuz>
Component: Individual Port(s)Assignee: Robert Clausecker <fuz>
Status: Closed FIXED    
Severity: Affects Some People CC: fluffy, gnome, pavelivolkov
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
databases/evolution-data-server: make usable when sqlite3 has option DQS disabled fuz: maintainer-approval? (gnome)

Description Robert Clausecker freebsd_committer freebsd_triage 2024-04-08 08:59:23 UTC 
As a result of bug #277610, the DQS compatibility option of port databases/sqlite3 was disabled by default.  This change had been announced for quite a while in UPDATING after an initial attempt at changing this option (bug #269798, bug #270064) exposed a variety of compatibility issues.

Turns out mail/evolution is also among them.  With option DQS disabled, no new mail is received and things fail with the spurious error message:

    no such column: %s

Rebuilding databases/sqlite3 with DQS enabled fixes the issue.

See also: https://forums.freebsd.org/threads/evolution-glib-error-prevent-new-messages-from-being-displayed.88246/

There's probably a query somewhere that needs to be patched.  Shouldn't be too hard once it's found.

I was unable to find a corresponding upstream bug report, but will file one once I find it.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2024-04-08 09:57:09 UTC 
Created attachment 249825 [details]
databases/evolution-data-server: make usable when sqlite3 has option DQS disabled

Attached is a patch that fixes the issue for me.
Please LGTM so I can commit this one with my next batch.
Comment 2 Dima Panov freebsd_committer freebsd_triage 2024-04-09 12:20:52 UTC 
LGTM

Go forward
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-04-12 08:38:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=50154e657e63e12df3938dcd7dc15b7e340f5a6f

commit 50154e657e63e12df3938dcd7dc15b7e340f5a6f
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2024-04-08 09:52:26 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-04-12 08:36:56 +0000

    databases/evolution-data-server: make usable when sqlite3 has option DQS disabled

    This port uses "%s" in some SQL queries where '%s' should have been
    used.  When the DQS (double-quoted string) misfeatures of SQLite3 is
    disabled, these queries fail and cause the error "no such column: %s".
    Change these queries to fix evolution.

    PR:             278249
    Approved by:    fluffy (gnome)
    MFH:            2024Q2

 databases/evolution-data-server/Makefile           |  2 +-
 .../files/patch-src_camel_camel-db.c (new)         | 36 ++++++++++++++++++++++
 2 files changed, 37 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-04-12 08:40:16 UTC 
A commit in branch 2024Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7f9936379856372d8dd8d7a7eb005a0fd94b1b6b

commit 7f9936379856372d8dd8d7a7eb005a0fd94b1b6b
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2024-04-08 09:52:26 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-04-12 08:39:16 +0000

    databases/evolution-data-server: make usable when sqlite3 has option DQS disabled

    This port uses "%s" in some SQL queries where '%s' should have been
    used.  When the DQS (double-quoted string) misfeatures of SQLite3 is
    disabled, these queries fail and cause the error "no such column: %s".
    Change these queries to fix evolution.

    PR:             278249
    Approved by:    fluffy (gnome)
    MFH:            2024Q2

    (cherry picked from commit 50154e657e63e12df3938dcd7dc15b7e340f5a6f)

 databases/evolution-data-server/Makefile           |  2 +-
 .../files/patch-src_camel_camel-db.c (new)         | 36 ++++++++++++++++++++++
 2 files changed, 37 insertions(+), 1 deletion(-)
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2024-04-12 08:40:24 UTC 
Thank you for the review.