Bug 278490
| Summary: | audio/sdl2_mixer: Improvements to port | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | diizzy | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(amdmi3) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Regarding release archive/tarball, https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github Options refactoring accepted. pkgconfig dependency is not needed. Multiple dependencies uses pkgconfig ? See https://github.com/libsdl-org/SDL_mixer/blob/release-2.8.0/cmake/FindOpusFile.cmake for example https://cmake.org/cmake/help/latest/module/FindPkgConfig.html I've only looked into CMakeLists.txt, you're right. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=6384812843afff595ff21a8b3378e3321bc64e7c commit 6384812843afff595ff21a8b3378e3321bc64e7c Author: Dmitry Marakasov <amdmi3@FreeBSD.org> AuthorDate: 2024-04-22 18:45:19 +0000 Commit: Dmitry Marakasov <amdmi3@FreeBSD.org> CommitDate: 2024-04-22 18:45:50 +0000 audio/sdl2_mixer: Add missing pkgconfig dependency PR: 278490 Submitted by: diizzy audio/sdl2_mixer/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) |
Created attachment 250115 [details] Patch for sdl2_mixer * Use upstream release archive * Reduce I/O by excluding unused content in repo * Define pkgconfig as a dependency * Sort menu options * Sort CMake options * Remove stray OGG definition from OPTIONS_RADIO No functional change