Bug 27851

Summary: gif interfaces don't have IFF_RUNNING flag bit set.
Product: Base System Reporter: horape <horape>
Component: kernAssignee: Yar Tikhiy <yar>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.2-RELEASE   
Hardware: Any   
OS: Any   

Description horape 2001-06-03 08:00:13 UTC
gif interfaces don't have IFF_RUNNING flag bit set, it probably should.

net-snmp maps IFF_RUNNING to ifAdminStatus. Since FBSD don't set
IFF_RUNNING on gif interfaces it looks like they're ifconfig'ed down.

Fix: 

-               ifp->if_flags |= IFF_UP;
+               ifp->if_flags |= IFF_UP | IFF_RUNNING;
                if_up(ifp);             /* send up RTM_IFINFO */

                error = 0;--CJOpomIU9b8A87t3YyTGXuiMGa0LNhXesNxi1Mk95sfypPDp
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- sys/net/if_gif.c.orig       Sun Jun  3 03:50:43 2001
+++ sys/net/if_gif.c    Sun Jun  3 03:50:57 2001
@@ -537,7 +537,7 @@
                bcopy((caddr_t)dst, (caddr_t)sa, size);
                sc->gif_pdst = sa;
How-To-Repeat: 'ifconfig gifN' on any working gif interface
Comment 1 Yar Tikhiy freebsd_committer freebsd_triage 2001-06-03 18:31:36 UTC
State Changed
From-To: open->analyzed

Thanx, fixed in -current. 


Comment 2 Yar Tikhiy freebsd_committer freebsd_triage 2001-06-03 18:31:36 UTC
Responsible Changed
From-To: freebsd-bugs->yar

So I won't forget to MFC the fix.
Comment 3 Yar Tikhiy freebsd_committer freebsd_triage 2001-06-07 14:09:58 UTC
State Changed
From-To: analyzed->closed

Fixed in -current and -stable, thanx!