Bug 278510
| Summary: | net/sdl2_net: Use upstream release archive | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||
| Status: | Closed Not Accepted | ||||||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(amdmi3) |
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
> Switch to upstream's official release archive This hinders both port maintainability (see sdl2_sound port to see what it's useful for) and security (recent xz case). Please do not suggest this change any more. > Don't extract files we don't need (saves about 10Mbyte) Unjustified complication for no measurable gain. Similar thing for other PRs. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5b634162c6b63002436e316c8f35b442bb58f41c commit 5b634162c6b63002436e316c8f35b442bb58f41c Author: Dmitry Marakasov <amdmi3@FreeBSD.org> AuthorDate: 2024-04-22 18:12:51 +0000 Commit: Dmitry Marakasov <amdmi3@FreeBSD.org> CommitDate: 2024-04-22 18:20:02 +0000 audio/sdl2_mixer: sort options, remove stray OGG option PR: 278510 Submitted by: diizzy audio/sdl2_mixer/Makefile | 53 ++++++++++++++++++++--------------------------- 1 file changed, 23 insertions(+), 30 deletions(-) > Don't extract files we don't need (saves about 10Mbyte)
Unjustified complication for no measurable gain.
If you look across 4 affected ports (sdl2_net,sdl2_tff,sdl2_image,sdl2_mixer) we save close to 50Mbyte of pointless I/O (XCode alone is 11.5Mbyte). That's measurable on spinning rust and wear on SSDs. There are no complications apart from a few directories not being extracted? I'd agree if we would need additional patching though.
> If you look across 4 affected ports (sdl2_net,sdl2_tff,sdl2_image,sdl2_mixer) we save close to 50Mbyte of pointless I/O (XCode alone is 11.5Mbyte). That's measurable on spinning rust and wear on SSDs. These ports are rebuilt once a month at most, so no it is not, neither absolutely, nor compared to I/O generated by other ports. > There are no complications apart from a few directories not being extracted? I'd agree if we would need additional patching though. Each extra line has a non-zero maintenance cost, which will never pay off in this case. You are already doing it in in sdl2_image so why not make an improvement? https://cgit.freebsd.org/ports/tree/graphics/sdl2_image/Makefile#n53 |
Created attachment 250137 [details] Patch for sdl2_net * Switch to upstream's official release archive * Don't extract files we don't need (saves about 10Mbyte)