Bug 278665

Summary: mail/mlmmj: unconditional dependency on atf brings in huge indirect dependency list
Product: Ports & Packages Reporter: Siva Mahadevan <me>
Component: Individual Port(s)Assignee: Baptiste Daroussin <bapt>
Status: Closed FIXED    
Severity: Affects Only Me CC: me
Priority: --- Flags: bugzilla: maintainer-feedback? (bapt)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
[PATCH] mail/mlmmj: move kyua and atf BUILD_DEPENDS to new TEST option none

Description Siva Mahadevan 2024-04-30 15:34:45 UTC
Created attachment 250307 [details]
[PATCH] mail/mlmmj: move kyua and atf BUILD_DEPENDS to new TEST option

mlmmj has --enable-tests by default, which requires kyua and atf as BUILD_DEPENDS. atf depends on lutok, which brings in a huge list (~1GiB+) of indirect dependencies by default. My attached patch adds a TEST option similar to a lot of other ports, which conditionally enables tests and prevents these unnecessary dependencies from being added.
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-06-17 08:36:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2612aa236edb789960eaa10420b008de8da148b7

commit 2612aa236edb789960eaa10420b008de8da148b7
Author:     Baptiste Daroussin <bapt@FreeBSD.org>
AuthorDate: 2024-06-17 08:32:22 +0000
Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
CommitDate: 2024-06-17 08:35:03 +0000

    mail/mlmmj: reduce the number of dependencies necessary to build

    Use the "testing" Feature" to activate testing

    PR:     278665

 Mk/bsd.options.mk   |  1 +
 mail/mlmmj/Makefile | 11 ++++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)
Comment 2 Baptiste Daroussin freebsd_committer freebsd_triage 2024-06-17 08:36:47 UTC
I have done it another way using the testing feature instead of adding an option.
Comment 3 Siva Mahadevan 2024-06-17 14:59:56 UTC
Ah cool, looks like a relatively new feature, I missed this. Thanks!