Bug 278693 (cmake-3.29.2)

Summary: [exp-run] devel/cmake: Update to 3.29.2
Product: Ports & Packages Reporter: Jason E. Hale <jhale>
Component: Individual Port(s)Assignee: Jason E. Hale <jhale>
Status: Closed FIXED    
Severity: Affects Only Me CC: kde
Priority: --- Flags: antoine: exp-run+
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://people.freebsd.org/~jhale/patches/0001-devel-cmake-Update-to-3.29.2.patch
Attachments:
Description Flags
v1 none

Description Jason E. Hale freebsd_committer freebsd_triage 2024-05-02 00:33:19 UTC 
Created attachment 250326 [details]
v1

Moin moin!

kde@ would like to ask for an exp-run to update devel/cmake and friends to 3.29.2. This also includes an update of devel/ninja to 1.12.0.

Patch is attached and can also be found here: https://people.freebsd.org/~jhale/patches/0001-devel-cmake-Update-to-3.29.2.patch
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-05-06 09:32:07 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=26bc7a808a737b163b5f908325450b1c8296e4cb

commit 26bc7a808a737b163b5f908325450b1c8296e4cb
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-05-06 08:09:01 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-05-06 09:31:04 +0000

    audio/muse-sequencer: ninja >= 1.12.0 build fix

    Add pending upstreamed patch [1] to fix the build with ninja >= 1.12.0.

    [1] https://github.com/muse-sequencer/muse/pull/1277

    PR:             278693
    Approved by:    portmgr (blanket)

 .../files/patch-muse_components_confmport.cpp (new)        | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-05-07 09:06:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=35d45549fc975bcf40590c38f6aa1dec5fbb38b8

commit 35d45549fc975bcf40590c38f6aa1dec5fbb38b8
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-05-07 04:57:45 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-05-07 09:05:20 +0000

    science/InsightToolkit: Fix build with CMake 3.29

    Support for the Comeau compiler was removed. Upstream has since updated
    it's copy of VNL, which doesn't require this patch.

    PR:             278693
    Approved by:    portmgr (blanket)

 ...arty_VNL_src_vxl_vcl_tests_test__preprocessor.cxx (new) | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-05-07 09:06:12 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bf067dc10cfd953b3a49ce2fdd4b89e34b3dcf98

commit bf067dc10cfd953b3a49ce2fdd4b89e34b3dcf98
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-05-07 08:11:25 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-05-07 09:05:20 +0000

    net-im/psi: Fix build with ninja >= 1.12.0

    Address a race condition where included headers generated by uic are
    not created before they used in the build.

    Not upstreaming this as the last release was in 2020 and the codebase
    has diverged too much since then.

    PR:             278693
    Approved by:    portmgr (blanket)

 net-im/psi/files/patch-src_tabs_CMakeLists.txt (new) | 10 ++++++++++
 1 file changed, 10 insertions(+)
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-05-08 09:50:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7bfbd1d1f55a76537ef8923b903507f9a682bcb8

commit 7bfbd1d1f55a76537ef8923b903507f9a682bcb8
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-05-08 09:44:49 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-05-08 09:48:58 +0000

    devel/fbthrift: Fix build with ninja >= 1.12.0

    Address a potential race condition where generated headers not created
    before they used in the build.

    https://github.com/facebook/fbthrift/pull/599

    PR:             278693
    Approved by:    portmgr (blanket)

 .../files/patch-thrift_lib_cpp2_CMakeLists.txt (new)   | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-05-15 04:19:31 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8beb8289395df3672318409f0674d8f6084d8fd9

commit 8beb8289395df3672318409f0674d8f6084d8fd9
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-05-11 05:01:44 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-05-15 04:11:42 +0000

    www/ungoogled-chromium: Fix build with ninja 1.12.0

    Fix race conditions where generated headers are not created before they
    are needed in the build.

    PR:             278693
    Approved by:    portmgr (blanket)

 .../files/patch-chrome_browser_devtools_BUILD.gn (new)   | 10 ++++++++++
 .../files/patch-chrome_browser_extensions_BUILD.gn       | 12 ++++++++++--
 www/ungoogled-chromium/files/patch-net_dns_BUILD.gn      | 16 +++++++++++++---
 3 files changed, 33 insertions(+), 5 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-05-15 04:19:32 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=923eae5c85ec6db32f326d9e32acfd605b10087b

commit 923eae5c85ec6db32f326d9e32acfd605b10087b
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-05-15 03:31:08 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-05-15 04:11:51 +0000

    www/iridium: Fix build with ninja 1.12.0

    Fix race conditions where generated headers are not created before they
    are needed in the build.

    Ninja 1.12.0 removed the `-w dupbuild` option and the default behavior
    is now equivalent to passing `-w dupbuild=err` in previous versions.

    PR:             278693
    Approved by:    portmgr (blanket)

 .../patch-chrome_browser_devtools_BUILD.gn (new)   | 10 ++++
 ...ch-chrome_browser_safe__browsing_BUILD.gn (new) | 10 ++++
 www/iridium/files/patch-components_BUILD.gn (new)  | 22 +++++++++
 www/iridium/files/patch-content_browser_BUILD.gn   | 57 +++++++++++++++++++---
 www/iridium/files/patch-net_BUILD.gn               | 22 ++++++---
 www/iridium/files/patch-net_dns_BUILD.gn           | 16 ++++--
 .../patch-tools_gn_bootstrap_bootstrap.py (new)    | 11 +++++
 7 files changed, 130 insertions(+), 18 deletions(-)
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-05-15 04:19:33 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6d647fd89751c8e535d8b3b332844b7f6cc6389a

commit 6d647fd89751c8e535d8b3b332844b7f6cc6389a
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-05-11 04:12:01 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-05-15 04:11:36 +0000

    www/chromium: Fix build with ninja 1.12.0

    Fix race conditions where generated headers are not created before they
    are needed in the build.

    PR:             278693
    Approved by:    portmgr (blanket)

 .../files/patch-chrome_browser_devtools_BUILD.gn (new)   | 10 ++++++++++
 www/chromium/files/patch-net_dns_BUILD.gn                | 16 +++++++++++++---
 2 files changed, 23 insertions(+), 3 deletions(-)
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-05-15 04:19:34 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4dc1764a37e029e61ab74d6292f28a88782081c2

commit 4dc1764a37e029e61ab74d6292f28a88782081c2
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-05-15 04:02:21 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-05-15 04:11:18 +0000

    devel/electron28: Fix build with ninja 1.12.0

    Fix race conditions where generated headers are not created before they
    are needed in the build.

    Ninja 1.12.0 removed the `-w dupbuild` option and the default behavior
    is now equivalent to passing `-w dupbuild=err` in previous versions.

    PR:             278693
    Approved by:    portmgr (blanket)

 devel/electron28/files/patch-net_dns_BUILD.gn            | 16 +++++++++++++---
 .../files/patch-tools_gn_bootstrap_bootstrap.py (new)    | 11 +++++++++++
 2 files changed, 24 insertions(+), 3 deletions(-)
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-05-15 04:19:35 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a80c93491deebb797e3f8e520bb64155730339a3

commit a80c93491deebb797e3f8e520bb64155730339a3
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-05-15 04:01:11 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-05-15 04:11:11 +0000

    devel/electron27: Fix build with ninja 1.12.0

    Fix race conditions where generated headers are not created before they
    are needed in the build.

    Ninja 1.12.0 removed the `-w dupbuild` option and the default behavior
    is now equivalent to passing `-w dupbuild=err` in previous versions.

    PR:             278693
    Approved by:    portmgr (blanket)

 devel/electron27/files/patch-net_dns_BUILD.gn            | 16 +++++++++++++---
 .../files/patch-tools_gn_bootstrap_bootstrap.py (new)    | 11 +++++++++++
 2 files changed, 24 insertions(+), 3 deletions(-)
Comment 11 commit-hook freebsd_committer freebsd_triage 2024-05-15 04:19:36 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8fed35cd38a5a5ded99113e7f23044d32d1190a8

commit 8fed35cd38a5a5ded99113e7f23044d32d1190a8
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-05-15 04:06:03 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-05-15 04:11:25 +0000

    devel/electron29: Fix build with ninja 1.12.0

    Fix race conditions where generated headers are not created before they
    are needed in the build.

    Ninja 1.12.0 removed the `-w dupbuild` option and the default behavior
    is now equivalent to passing `-w dupbuild=err` in previous versions.

    PR:             278693
    Approved by:    portmgr (blanket)

 devel/electron29/files/patch-net_dns_BUILD.gn            | 16 +++++++++++++---
 .../files/patch-tools_gn_bootstrap_bootstrap.py (new)    | 11 +++++++++++
 2 files changed, 24 insertions(+), 3 deletions(-)
Comment 12 commit-hook freebsd_committer freebsd_triage 2024-05-15 04:19:37 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4da1e7401561ac8d28da1837b0e5937788f8f099

commit 4da1e7401561ac8d28da1837b0e5937788f8f099
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-05-11 22:57:57 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-05-15 04:11:00 +0000

    devel/electron25: Fix build with ninja 1.12.0

    Fix race conditions where generated headers are not created before they
    are needed in the build.

    Ninja 1.12.0 removed the `-w dupbuild` option and the default behavior
    is now equivalent to passing `-w dupbuild=err` in previous versions.

    PR:             278693
    Approved by:    portmgr (blanket)

 devel/electron25/files/patch-net_dns_BUILD.gn                | 12 +++++++++++-
 .../files/patch-tools_gn_bootstrap_bootstrap.py (new)        | 11 +++++++++++
 2 files changed, 22 insertions(+), 1 deletion(-)
Comment 13 commit-hook freebsd_committer freebsd_triage 2024-05-15 04:19:38 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=601ee778fe0f8cf0fba8685757a7afca63c37691

commit 601ee778fe0f8cf0fba8685757a7afca63c37691
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-05-11 04:03:51 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-05-15 04:16:11 +0000

    www/qt5-webengine: Fix build with ninja 1.12.0

    Fix race conditions where generated headers are not created before they
    are needed in the build.

    PR:             278693

 ...-src_3rdparty_chromium_content_browser_BUILD.gn | 32 ++++++++++++++++------
 1 file changed, 24 insertions(+), 8 deletions(-)
Comment 14 Jason E. Hale freebsd_committer freebsd_triage 2024-05-15 18:30:45 UTC 
Now that Qt 6.7.0 has landed, all known issues should be fixed.
Comment 16 commit-hook freebsd_committer freebsd_triage 2024-05-18 14:49:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2204bdcd430ced9d330580ca4ccd7bb1462a98b6

commit 2204bdcd430ced9d330580ca4ccd7bb1462a98b6
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-05-18 14:45:28 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-05-18 14:47:22 +0000

    science/InsightToolkit501: Fix build with CMake 3.29

    Support for the Comeau compiler was removed.

    PR:             278693

 ...arty_VNL_src_vxl_vcl_tests_test__preprocessor.cxx (new) | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Comment 17 Jason E. Hale freebsd_committer freebsd_triage 2024-05-18 14:53:13 UTC 
Ah, I missed the '501' part of science/InsightToolkit501, just fixing the non-versioned science/InsightToolkit initially. Fixed now and I tested its only consumer, graphics/vv.
Comment 18 commit-hook freebsd_committer freebsd_triage 2024-05-19 00:36:25 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8c719da72f4821aea450922eee93f77bbe3d9e2b

commit 8c719da72f4821aea450922eee93f77bbe3d9e2b
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-05-01 04:05:25 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-05-19 00:36:07 +0000

    devel/cmake*: Update to 3.29.2

    Qt5 support has been removed from devel/cmake-gui. The kde@ team
    recommends migrating away from Qt5 and using Qt6 for individual
    applications whenever possible.

    Announcements:
    https://www.kitware.com/cmake-3-29-0-available-for-download/
    https://www.kitware.com/cmake-3-29-1-available-for-download/
    https://www.kitware.com/cmake-3-29-2-available-for-download/

    Release notes:
    https://cmake.org/cmake/help/latest/release/3.29.html

    PR:             278693
    Exp-run by:     antoine

 Mk/Uses/cmake.mk           |  2 +-
 devel/cmake-core/distinfo  |  6 ++---
 devel/cmake-core/pkg-plist | 57 ++++++++++++++++++++++++++++++++++++++++++++-
 devel/cmake-doc/pkg-plist  | 58 ++++++++++++++++++++++++++++++++++++++++++++++
 devel/cmake-gui/Makefile   | 16 ++++---------
 5 files changed, 123 insertions(+), 16 deletions(-)
Comment 19 commit-hook freebsd_committer freebsd_triage 2024-05-19 00:36:26 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bb0835fd3aa268260cc9eae4ba0cad55814d6265

commit bb0835fd3aa268260cc9eae4ba0cad55814d6265
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-05-01 04:05:25 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-05-19 00:36:08 +0000

    devel/ninja: Update to 1.12.0

    https://github.com/ninja-build/ninja/releases/v1.12.0

    PR:             278693
    Exp-run by:     antoine

 devel/ninja/Makefile | 20 +++++++++++++++-----
 devel/ninja/distinfo |  6 +++---
 2 files changed, 18 insertions(+), 8 deletions(-)
Comment 20 Jason E. Hale freebsd_committer freebsd_triage 2024-05-19 00:40:45 UTC 
Thanks for the exp-run, Antoine!