Bug 278754

Summary: games/xray_re-tools: Use EXTRACT_AFTER_ARGS
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Alexey Dokuchaev <danfe>
Status: In Progress ---    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (danfe)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for xray_re-tools
none
Patch for xray_re-tools v2 none

Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-04 18:58:47 UTC
Created attachment 250390 [details]
Patch for xray_re-tools

Instead of extracting unused dependencies just skip them instead to reduce I/O

Poudriere bulk OK
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-05-05 13:04:19 UTC
Created attachment 250446 [details]
Patch for xray_re-tools v2

Be more specific about what files to remove and preserve original flags
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2024-05-08 03:01:35 UTC
This one is particularly good example of why I'm skeptical about this little quest of yours, or rather its current form.  Here you want to replace one simple, readable, DRY line with three long, yet similar ones.  I need to think how to shorten this and make less error-prone, shall I decide to accept it.

Do you have plans to generalize the whole thing and make it part of the Mk/b.p.m framework, hiding all this ${GH_PROJECT_DEFAULT}-${GH_TAGNAME_EXTRACT} nastiness and repetitive --exclude's behind the curtain and, for multi-distfile ports, applied only to specific distfile that needs it?