Bug 278759

Summary: devel/pycharm-ce: Use EXTRACT_AFTER_ARGS
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Daniel Engberg <diizzy>
Status: Closed FIXED    
Severity: Affects Only Me CC: jonc
Priority: --- Flags: jonc: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for pycharm-ce
none
Patch for pycharm-ce v2 none

Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-04 19:11:08 UTC
Created attachment 250395 [details]
Patch for pycharm-ce

Skip extracting unnecessary files instead of deleting them after extraction to reduice I/O

Poudriere bulk OK
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-05-05 11:32:37 UTC
Created attachment 250427 [details]
Patch for pycharm-ce v2

Be more specific about what files to remove and preserve original flags
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-05-05 11:33:18 UTC
Thanks, given it's a minor fix I'll consider the new patch as approved as well
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-05-06 20:26:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dc99303b1691df946e9223cc9756e120e1ff38ec

commit dc99303b1691df946e9223cc9756e120e1ff38ec
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-05-06 20:02:58 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-05-06 20:08:41 +0000

    devel/pycharm-ce: Use EXTRACT_AFTER_ARGS

    To decrease I/O load skip extracting files instead of removing after
    extraction

    PR:             278759
    Reviewed by:    Jonathan Chen <jonc@chen.org.nz> (maintainer, previous version)

 devel/pycharm-ce/Makefile | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-05-06 20:30:39 UTC
Committed, thanks!