Summary: | lang/ruby3[1-3]: Convert post-patch to EXTRACT_AFTER_ARGS and use helpers | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||||
Component: | Individual Port(s) | Assignee: | Yasuhiro Kimura <yasu> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | diizzy, yasu | ||||||
Priority: | --- | Flags: | yasu:
maintainer-feedback+
|
||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Created attachment 250451 [details]
Patch for ruby32 v2
Be more specific about what files to remove and preserve original flags
(In reply to Daniel Engberg from comment #1) Thanks for patch. +# We get these from other ports +EXTRACT_AFTER_ARGS= --exclude ${DISTNAME}/bin/gem \ + --exclude ${DISTNAME}/ext/win32* \ + --exclude ${DISTNAME}/lib/bundler* \ + --exclude ${DISTNAME}/libexec/bundler \ + --exclude ${DISTNAME}/man/erb.1 \ + --exclude ${DISTNAME}/man/irb.1 \ + --exclude ${DISTNAME}/man/ri.1 \ + --no-same-owner --no-same-permissions + Would you please explain why last two options are necessary? Hi, They're default ones in the framework. See https://cgit.freebsd.org/ports/tree/Mk/bsd.port.mk#n2154 Best regards, Daniel (In reply to Daniel Engberg from comment #3) Thanks for explanation. BTW the change seems to be applicable to other ruby versions. So would you please apply it to them too? Regards. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=84f001c6c642cf3c87f6fc4a0a1327dc5182cf1c commit 84f001c6c642cf3c87f6fc4a0a1327dc5182cf1c Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-05-14 04:26:43 +0000 Commit: Yasuhiro Kimura <yasu@FreeBSD.org> CommitDate: 2024-05-14 04:26:43 +0000 lang/ruby3[1-3]: Refine ports * Skip extracting unnecessary files by setting EXTRACT_AFTER_ARGS instead of removing them with post-patch target after they are extracted. * Use 'USES=localbase' to set path of header and library files. PR: 278764 lang/ruby31/Makefile | 22 ++++++++++++---------- lang/ruby32/Makefile | 22 ++++++++++++---------- lang/ruby33/Makefile | 22 ++++++++++++---------- 3 files changed, 36 insertions(+), 30 deletions(-) Committed. Thanks! Thanks for adapting this to the other ruby ports! |
Created attachment 250399 [details] Patch for ruby32 Skip extracting files instead of discarding them after extraction to reduice I/O While at it also use USES= localbase instead of setting it by hand Poudriere bulk OK