Bug 278793
| Summary: | x11-fonts/fira: Simplify port | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||
| Component: | Individual Port(s) | Assignee: | Daniel Engberg <diizzy> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | trueos | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(trueos) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Comment on attachment 250468 [details]
Patch for fira
I approve of this patch. We don't need a "DOCS" option. I guess since you are going touching this port, you could also remove the mention to www/fira-webfont in pkg-message.in.
I do think that port existed at some point, but it does not exist now.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ac8a8a98c1a76070d4be08b292cca599ef1ab3f1 commit ac8a8a98c1a76070d4be08b292cca599ef1ab3f1 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-05-07 18:19:48 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-05-07 19:26:02 +0000 x11-fonts/fira: Simplify port * Just extract what we really need which makes it cleaner and reduces I/O. * Drop DOCS option * Remove reference of www/fira-webfont (pointed out by maintainer) PR: 278793 Reviewed by: Trenton Schulz <trueos@norwegianrockcat.com> (maintainer) x11-fonts/fira/Makefile | 30 ++++++++++++++---------------- x11-fonts/fira/files/pkg-message.in | 1 - 2 files changed, 14 insertions(+), 17 deletions(-) Committed, thanks |
Created attachment 250468 [details] Patch for fira Just extract what we really need which makes it cleaner and faster