Bug 278861

Summary: sysutils/libcdio: Disable CDDB support
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Jason E. Hale <jhale>
Status: Closed FIXED    
Severity: Affects Only Me Flags: jhale: maintainer-feedback+
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for libcdio none

Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-09 05:40:09 UTC 
Created attachment 250540 [details]
Patch for libcdio

Broken, follow suite of others distros and disable support
While at it disable support for vcd-info and adjust Makefile for readability

Reference:
https://hydrogenaud.io/index.php?PHPSESSID=029bfbfmciujgqp7o212mip5vd&topic=125880.0
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-05-17 18:51:22 UTC 
Friendly ping
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-05-18 15:26:11 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1111d2b95613b16e4cd0b1425e244de1f777d41f

commit 1111d2b95613b16e4cd0b1425e244de1f777d41f
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-05-18 15:23:57 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-05-18 15:25:43 +0000

    sysutils/libcdio: Disable broken CDDB support

    While here, pet portclippy(1) and portlint(1).

    PR:             278861

 sysutils/libcdio/Makefile | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)
Comment 3 Jason E. Hale freebsd_committer freebsd_triage 2024-05-18 15:31:46 UTC 
Committed, but I ordered the Makefile according to portclippy(1). Please be careful to use tabs instead of spaces when declaring variables. Using portlint(1) would have caught this.