Bug 278920

Summary: print/cups: Some Makefile tweaks
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Tijl Coosemans <tijl>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (tijl)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for cups none

Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-11 19:09:19 UTC
Created attachment 250589 [details]
Patch for cups

- Don't abuse EXTRACT_SUFX, use DISTNAME and WRKSRC
- Do some minor rearrangement for better readability
Comment 1 Tijl Coosemans freebsd_committer freebsd_triage 2024-05-11 19:31:02 UTC
(In reply to Daniel Engberg from comment #0)
OK for the first point, but can you run portclippy for the second one?
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-05-11 22:44:14 UTC
Feel free to pick what parts you like

portclippy orders things oddly and it's not something we follow in tree so I don't know what you want to change.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-06-21 10:42:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9a4fe7c6ba1b371db3b8dc0dd5fc6a024c8e2a4d

commit 9a4fe7c6ba1b371db3b8dc0dd5fc6a024c8e2a4d
Author:     Tijl Coosemans <tijl@FreeBSD.org>
AuthorDate: 2024-06-21 08:36:22 +0000
Commit:     Tijl Coosemans <tijl@FreeBSD.org>
CommitDate: 2024-06-21 10:40:06 +0000

    print/cups: Update to 2.4.10

    Pet portclippy/portfmt.

    PR:             278920, 279883

 print/cups/Makefile | 51 ++++++++++++++++++++++++++-------------------------
 print/cups/distinfo |  6 +++---
 2 files changed, 29 insertions(+), 28 deletions(-)