Bug 279141

Summary: irc/soju: enable PAM support and fix build tag addition to GOFLAGS
Product: Ports & Packages Reporter: Siva Mahadevan <me>
Component: Individual Port(s)Assignee: Ashish SHUKLA <ashish>
Status: Closed FIXED    
Severity: Affects Only Me Flags: ashish: maintainer-feedback+
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
[PATCH] irc/soju: enable PAM support and fix build tag addition to GOFLAGS none

Description Siva Mahadevan 2024-05-18 20:44:18 UTC 
Created attachment 250799 [details]
[PATCH] irc/soju: enable PAM support and fix build tag addition to GOFLAGS

Since USES=go:no_targets was used, GO_BUILDFLAGS were not being added to the `make` command. However, the upstream project also doesn't take GO_BUILDFLAGS from the make environment, so those build tags were never being propagated to the actual go build command.

This patch fixes that by explicitly adding the build tags to GOFLAGS, just like outlined in the upstream documentation: https://git.sr.ht/~emersion/soju
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-05-22 22:17:37 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c8c7a6d175aba07e9ddf8ddd622e42a9d9d7603f

commit c8c7a6d175aba07e9ddf8ddd622e42a9d9d7603f
Author:     Siva Mahadevan <me@svmhdvn.name>
AuthorDate: 2024-05-18 20:40:33 +0000
Commit:     Ashish SHUKLA <ashish@FreeBSD.org>
CommitDate: 2024-05-22 22:15:12 +0000

    irc/soju: enable PAM support and fix build tag addition to GOFLAGS

    PR:             279141

 irc/soju/Makefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Comment 2 Ashish SHUKLA freebsd_committer freebsd_triage 2024-05-22 22:45:44 UTC 
Thanks, committed with a change.