Bug 279150

Summary: misc/hotkeys: Patch needed due to deprecation of databases/db5
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Daniel Engberg <diizzy>
Status: Open ---    
Severity: Affects Only Me CC: fernape, portmaster
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
git diff against misc/hpotkeys
portmaster: maintainer-approval+
git diff against misc/hotkeys
portmaster: maintainer-approval+
git diff against misc/hotkeys portmaster: maintainer-approval+

Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-19 06:27:29 UTC 
Hi,

This port is marked as incompatible with version 18, please perpare a patch or deprecate port.
Comment 1 Chris Hutchinson 2024-05-20 01:08:55 UTC 
(In reply to Daniel Engberg from comment #0)
Thanks for the heads-up, Daniel.
I think it works with 18. But I'll check again, and prepare
something acceptable by tomorrow.

--Chris
Comment 2 Chris Hutchinson 2024-05-20 03:58:13 UTC 
Created attachment 250824 [details]
git diff against misc/hpotkeys

git diff to upgrade dbd USES to dbd-18

All tests return OK.

Thanks.

--Chris
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2024-05-20 14:01:37 UTC 
^Triage: Reporter is committer, assign accordingly.
Comment 4 Chris Hutchinson 2024-05-20 16:13:32 UTC 
Please hold up on this. I have another patch
I'd like to replace this one with. That addresses
a couple of other issues. Give me an hour.

Thanks.
Comment 5 Chris Hutchinson 2024-05-20 18:46:22 UTC 
Created attachment 250836 [details]
git diff against misc/hotkeys

OK this one cleans up some things I neglected to
do in the last patch. Passes all tests with the
exception of one of the patch files (warn). I'm
moving this to a public VCS (codeberg) and will
make some additional improvements for a newer version.
But this will address everything that matters, as well
as moving this to BDB-18.

Files affected:
Makefile
distinfo
files/patch-configure
files/patch-src-Makefile
files/patch-src-conf.c
files/patch-src-hotkeys.conf
files/patch-src-kbddef.c
files/patch-src-kbddef.h

That's it.

Thanks.

--Chris
Comment 6 Chris Hutchinson 2024-05-20 20:45:42 UTC 
Created attachment 250837 [details]
git diff against misc/hotkeys

Since this hasn't been committed yet...
Update previous diff to include the conversion
of files/patch-src-hotkeys.c from a git diff
to diff proper. Sorry for all the previous noise.

Files affected:
Makefile
distinfo
files/patch-configure
files/patch-src-Makefile
files/patch-src-conf.c
files/patch-src-hotkeys.c
files/patch-src-hotkeys.conf
files/patch-src-kbddef.c
files/patch-src-kbddef.h

This patch is complete and final as far as I'm
concerned. :)

Thanks for your time on this Daniel.

--Chris